Remove auto-call to canvas.draw_idle in ResizeEvent processing.

anntzer · anntzer · commit a1b7b7b89fb3 · 2022-07-12T22:41:59.000+02:00
Backends can call draw_idle themselves.  Note that 1) this was already
done by the gtk backends, and 2) this may actually be unneeded, as
figure.set_size_inches (which is always called a bit earlier by the
various resize handlers) also marks the figure as stale, which should
trigger a redraw too.  Still, let's add the draw_idle calls to be safe,
they shouldn't be costly as both draws should get compressed together;
we can always investigate removing them later.
diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py
@@ -1277,10 +1277,6 @@ def __init__(self, name, canvas):
         super().__init__(name, canvas)
         self.width, self.height = canvas.get_width_height()
 
-    def _process(self):
-        super()._process()
-        self.canvas.draw_idle()
-
 
 class CloseEvent(Event):
     """An event triggered by a figure being closed."""
diff --git a/lib/matplotlib/backends/_backend_tk.py b/lib/matplotlib/backends/_backend_tk.py
@@ -241,6 +241,7 @@ def resize(self, event):
         self._tkcanvas.create_image(
             int(width / 2), int(height / 2), image=self._tkphoto)
         ResizeEvent("resize_event", self)._process()
+        self.draw_idle()
 
     def draw_idle(self):
         # docstring inherited
diff --git a/lib/matplotlib/backends/backend_qt.py b/lib/matplotlib/backends/backend_qt.py
@@ -348,6 +348,7 @@ def resizeEvent(self, event):
         QtWidgets.QWidget.resizeEvent(self, event)
         # emit our resize events
         ResizeEvent("resize_event", self)._process()
+        self.draw_idle()
 
     def sizeHint(self):
         w, h = self.get_width_height()
diff --git a/lib/matplotlib/backends/backend_webagg_core.py b/lib/matplotlib/backends/backend_webagg_core.py
@@ -343,6 +343,7 @@ def handle_resize(self, event):
         self._png_is_old = True
         self.manager.resize(*fig.bbox.size, forward=False)
         ResizeEvent('resize_event', self)._process()
+        self.draw_idle()
 
     def handle_send_image_mode(self, event):
         # The client requests notification of what the current image mode is.
diff --git a/lib/matplotlib/backends/backend_wx.py b/lib/matplotlib/backends/backend_wx.py
@@ -705,6 +705,7 @@ def _on_size(self, event):
         # the whole background is repainted.
         self.Refresh(eraseBackground=False)
         ResizeEvent("resize_event", self)._process()
+        self.draw_idle()
 
     def _get_key(self, event):
 
