Don't start a browser for visual tests on CI.

QuLogic · QuLogic · commit a89d7d2178bd · 2017-02-21T00:55:31.000-05:00
Travis may or may not have a browser installed, but AppVeyor definitely
does, so this saves a tiny bit of processing power per run.
diff --git a/appveyor.yml b/appveyor.yml
@@ -139,7 +139,7 @@ test_script:
   - if x%USE_PYTEST% == xyes py.test %PYTEST_ARGS%
   - if x%USE_PYTEST% == xno python tests.py %PYTEST_ARGS%
   # Generate a html for visual tests
-  - python visual_tests.py
+  - python visual_tests.py --no-browser
   - pip install codecov
   - codecov -e PYTHON_VERSION PLATFORM
 
@@ -180,7 +180,7 @@ artifacts:
 on_finish:
 
 on_failure:
-  - python visual_tests.py
+  - python visual_tests.py --no-browser
   - echo zipping images after a failure...
   - 7z a result_images.zip result_images\ |grep -v "Compressing"
   - appveyor PushArtifact result_images.zip
diff --git a/visual_tests.py b/visual_tests.py
@@ -6,6 +6,7 @@
 #   $ python visual_tests.py
 #
 
+import argparse
 import os
 from collections import defaultdict
 
@@ -44,7 +45,7 @@
 linked_image_template = '<a href="{0}"><img src="{0}"></a>'
 
 
-def run():
+def run(show_browser=True):
     """
     Build a website for visual comparison
     """
@@ -116,12 +117,21 @@ def run():
     with open(index, "w") as f:
         f.write(html)
 
-    try:
-        import webbrowser
-        webbrowser.open(index)
-    except:
+    show_message = not show_browser
+    if show_browser:
+        try:
+            import webbrowser
+            webbrowser.open(index)
+        except:
+            show_message = True
+
+    if show_message:
         print("Open {} in a browser for a visual comparison.".format(index))
 
 
 if __name__ == '__main__':
-    run()
+    parser = argparse.ArgumentParser()
+    parser.add_argument('--no-browser', action='store_true',
+                        help="Don't show browser after creating index page.")
+    args = parser.parse_args()
+    run(show_browser=not args.no_browser)
