Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ac00871

Browse files
committed
Mark inkscape 1.0 as unsupported (at least for now).
The command line args changed completely so _SVGConverter would need to be rewritted first.
1 parent b47fc9d commit ac00871

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

lib/matplotlib/__init__.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ def impl(args, regex, min_ver=None, ignore_exit_code=False):
309309
if min_ver is not None and version < min_ver:
310310
raise ExecutableNotFoundError(
311311
f"You have {args[0]} version {version} but the minimum "
312-
f"version supported by Matplotlib is {min_ver}.")
312+
f"version supported by Matplotlib is {min_ver}")
313313
return _ExecInfo(args[0], version)
314314
else:
315315
raise ExecutableNotFoundError(
@@ -330,7 +330,11 @@ def impl(args, regex, min_ver=None, ignore_exit_code=False):
330330
message = "Failed to find a Ghostscript installation"
331331
raise ExecutableNotFoundError(message)
332332
elif name == "inkscape":
333-
return impl(["inkscape", "-V"], "^Inkscape ([^ ]*)")
333+
info = impl(["inkscape", "-V"], "^Inkscape ([^ ]*)")
334+
if info and info.version >= "1.0":
335+
raise ExecutableNotFoundError(
336+
f"You have Inkscape version {info.version} but Matplotlib "
337+
f"only supports Inkscape<1.0")
334338
elif name == "magick":
335339
path = None
336340
if sys.platform == "win32":
@@ -367,7 +371,7 @@ def impl(args, regex, min_ver=None, ignore_exit_code=False):
367371
or "0.9" <= info.version <= "1.0"):
368372
raise ExecutableNotFoundError(
369373
f"You have pdftops version {info.version} but the minimum "
370-
f"version supported by Matplotlib is 3.0.")
374+
f"version supported by Matplotlib is 3.0")
371375
return info
372376
else:
373377
raise ValueError("Unknown executable: {!r}".format(name))

0 commit comments

Comments
 (0)