Remove mlab.rec_append_fields

dstansby · dstansby · commit ac0fc0849898 · 2018-09-29T11:05:09.000+01:00
diff --git a/doc/api/next_api_changes/2018-09-18-DS.rst b/doc/api/next_api_changes/2018-09-18-DS.rst
@@ -47,6 +47,7 @@ in Matplotlib 2.2 has been removed. See below for a list:
 - `mlab.rec_groupby`
 - `mlab.rec_keep_fields`
 - `mlab.rec_drop_fields`
+- `mlab.rec_append_fields`
 - `mlab.csvformat_factory`
 - `mlab.get_formatd`
 - `mlab.FormatDatetime` (use datetime.strftime instead)
diff --git a/lib/matplotlib/mlab.py b/lib/matplotlib/mlab.py
@@ -1543,41 +1543,6 @@ def safe_isinf(x):
         return b
 
 
-@cbook.deprecated("2.2")
-def rec_append_fields(rec, names, arrs, dtypes=None):
-    """
-    Return a new record array with field names populated with data
-    from arrays in *arrs*.  If appending a single field, then *names*,
-    *arrs* and *dtypes* do not have to be lists. They can just be the
-    values themselves.
-    """
-    if (not isinstance(names, str) and np.iterable(names)
-            and len(names) and isinstance(names[0], str)):
-        if len(names) != len(arrs):
-            raise ValueError("number of arrays do not match number of names")
-    else:  # we have only 1 name and 1 array
-        names = [names]
-        arrs = [arrs]
-    arrs = list(map(np.asarray, arrs))
-    if dtypes is None:
-        dtypes = [a.dtype for a in arrs]
-    elif not np.iterable(dtypes):
-        dtypes = [dtypes]
-    if len(arrs) != len(dtypes):
-        if len(dtypes) == 1:
-            dtypes = dtypes * len(arrs)
-        else:
-            raise ValueError("dtypes must be None, a single dtype or a list")
-    old_dtypes = rec.dtype.descr
-    newdtype = np.dtype(old_dtypes + list(zip(names, dtypes)))
-    newrec = np.recarray(rec.shape, dtype=newdtype)
-    for field in rec.dtype.fields:
-        newrec[field] = rec[field]
-    for name, arr in zip(names, arrs):
-        newrec[name] = arr
-    return newrec
-
-
 @cbook.deprecated("2.2")
 def csv2rec(fname, comments='#', skiprows=0, checkrows=0, delimiter=',',
             converterd=None, names=None, missing='', missingd=None,
diff --git a/lib/matplotlib/pylab.py b/lib/matplotlib/pylab.py
@@ -235,7 +235,7 @@
     frange,
     identity, ispower2, isvector, l1norm,
     l2norm, log2, movavg, norm_flat,
-    rec_append_fields, rms_flat,
+    rms_flat,
     window_hanning, window_none)
 
 from matplotlib import cbook, mlab, pyplot as plt
