Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ac1a4c5

Browse files
authored
Revert "Try to unbreak CI by xfailing OSX Tk tests (#23095)"
This reverts commit d6ee414.
1 parent d2f87e8 commit ac1a4c5

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

lib/matplotlib/tests/test_backend_tk.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,6 @@ def _isolated_tk_test(success_count, func=None):
3737
sys.platform == "linux" and not _c_internal_utils.display_is_valid(),
3838
reason="$DISPLAY and $WAYLAND_DISPLAY are unset"
3939
)
40-
@pytest.mark.xfail( # GitHub issue #23094
41-
sys.platform == 'darwin',
42-
reason="Tk version mismatch on OSX CI"
43-
)
4440
@functools.wraps(func)
4541
def test_func():
4642
# even if the package exists, may not actually be importable this can

lib/matplotlib/tests/test_backends_interactive.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,6 @@ def _get_testable_interactive_backends():
5959
elif env["MPLBACKEND"].startswith('wx') and sys.platform == 'darwin':
6060
# ignore on OSX because that's currently broken (github #16849)
6161
marks.append(pytest.mark.xfail(reason='github #16849'))
62-
elif env["MPLBACKEND"] == "tkagg" and sys.platform == 'darwin':
63-
marks.append( # GitHub issue #23094
64-
pytest.mark.xfail(reason="Tk version mismatch on OSX CI"))
6562
envs.append(
6663
pytest.param(
6764
{**env, 'BACKEND_DEPS': ','.join(deps)},
@@ -239,9 +236,6 @@ def _test_thread_impl():
239236
reason='PyPy does not support Tkinter threading: '
240237
'https://foss.heptapod.net/pypy/pypy/-/issues/1929',
241238
strict=True))
242-
elif backend == "tkagg" and sys.platform == "darwin":
243-
param.marks.append( # GitHub issue #23094
244-
pytest.mark.xfail("Tk version mismatch on OSX CI"))
245239

246240

247241
@pytest.mark.parametrize("env", _thread_safe_backends)
@@ -519,10 +513,6 @@ def _test_number_of_draws_script():
519513
elif backend == "wx":
520514
param.marks.append(
521515
pytest.mark.skip("wx does not support blitting"))
522-
elif backend == "tkagg" and sys.platform == "darwin":
523-
param.marks.append( # GitHub issue #23094
524-
pytest.mark.xfail("Tk version mismatch on OSX CI")
525-
)
526516

527517

528518
@pytest.mark.parametrize("env", _blit_backends)

0 commit comments

Comments
 (0)