Merge pull request #9295 from jklymak/textcheckpos

anntzer · web-flow · commit ad8ef637c04d · 2017-10-07T12:56:39.000-07:00
In text, warn and return instead of raise exception for non-finite x, y
diff --git a/lib/matplotlib/tests/test_text.py b/lib/matplotlib/tests/test_text.py
@@ -441,3 +441,10 @@ def test_two_2line_texts(spacing1, spacing2):
         assert box1.height == box2.height
     else:
         assert box1.height != box2.height
+
+
+def test_nonfinite_pos():
+    fig, ax = plt.subplots()
+    ax.text(0, np.nan, 'nan')
+    ax.text(np.inf, 0, 'inf')
+    fig.canvas.draw()
diff --git a/lib/matplotlib/text.py b/lib/matplotlib/text.py
@@ -20,7 +20,7 @@
 import matplotlib.artist as artist
 from matplotlib.artist import Artist
 from matplotlib.cbook import maxdict
-from matplotlib import docstring
+from matplotlib import docstring, verbose
 from matplotlib.font_manager import FontProperties
 from matplotlib.patches import FancyBboxPatch
 from matplotlib.patches import FancyArrowPatch, Rectangle
@@ -759,9 +759,12 @@ def draw(self, renderer):
             # position in Text, and dash position in TextWithDash:
             posx = float(textobj.convert_xunits(textobj._x))
             posy = float(textobj.convert_yunits(textobj._y))
-            if not np.isfinite(posx) or not np.isfinite(posy):
-                raise ValueError("posx and posy should be finite values")
             posx, posy = trans.transform_point((posx, posy))
+            if not np.isfinite(posx) or not np.isfinite(posy):
+                verbose.report("x and y are not finite values for text "
+                              "string '{}'.  Not rendering "
+                              "text.".format(self.get_text()), 'helpful')
+                return
             canvasw, canvash = renderer.get_canvas_width_height()
 
             # draw the FancyBboxPatch
