Fix font deduplication logic in createFontList.

anntzer · anntzer · commit af9e5115ced1 · 2019-03-16T12:44:33.000+01:00
Only add a font name to the "seen" list if one successfully extracts the
font properties from it; otherwise a first font that cannot be read
(e.g. due to permission issues) will mask a later font that can.
diff --git a/lib/matplotlib/font_manager.py b/lib/matplotlib/font_manager.py
@@ -517,8 +517,6 @@ def createFontList(fontfiles, fontext='ttf'):
         fname = os.path.split(fpath)[1]
         if fname in seen:
             continue
-        else:
-            seen.add(fname)
         if fontext == 'afm':
             try:
                 with open(fpath, 'rb') as fh:
@@ -551,6 +549,7 @@ def createFontList(fontfiles, fontext='ttf'):
                 continue
 
         fontlist.append(prop)
+        seen.add(fname)
     return fontlist
 
 
