Batch transform 3d ticks

scottshambaugh · scottshambaugh · commit b02182ced820 · 2026-01-18T20:41:21.000-07:00
diff --git a/lib/mpl_toolkits/mplot3d/axis3d.py b/lib/mpl_toolkits/mplot3d/axis3d.py
@@ -406,6 +406,10 @@ def _axmask(self):
     def _draw_ticks(self, renderer, edgep1, centers, deltas, highs,
                     deltas_per_point, pos):
         ticks = self._ticks_to_draw
+        n_ticks = len(ticks)
+        if n_ticks == 0:
+            return
+
         info = self._axinfo
         index = info["i"]
         juggled = info["juggled"]
@@ -431,23 +435,39 @@ def _draw_ticks(self, renderer, edgep1, centers, deltas, highs,
 
         default_label_offset = 8.  # A rough estimate
         points = deltas_per_point * deltas
-        # All coordinates below are in transformed coordinates for proper projection
-        for tick in ticks:
-            # Get tick line positions
-            pos = edgep1.copy()
-            pos[index] = axis_trans.transform([tick.get_loc()])[0]
-            pos[tickdir] = out_tickdir
-            x1, y1, z1 = proj3d.proj_transform(*pos, self.axes.M)
-            pos[tickdir] = in_tickdir
-            x2, y2, z2 = proj3d.proj_transform(*pos, self.axes.M)
-
-            # Get position of label
-            labeldeltas = (tick.get_pad() + default_label_offset) * points
-            pos[tickdir] = edgep1_tickdir
-            pos = _move_from_center(pos, centers, labeldeltas, self._axmask())
-            lx, ly, lz = proj3d.proj_transform(*pos, self.axes.M)
-
-            _tick_update_position(tick, (x1, x2), (y1, y2), (lx, ly))
+
+        # Collect tick data and batch transform tick locations
+        tick_locs = np.array([tick.get_loc() for tick in ticks])
+        tick_pads = np.array([tick.get_pad() for tick in ticks])
+        transformed_locs = axis_trans.transform(tick_locs)
+
+        # Build position arrays for tick line endpoints (shape: n_ticks x 3)
+        pos1 = np.tile(edgep1, (n_ticks, 1))
+        pos1[:, index] = transformed_locs
+        pos1[:, tickdir] = out_tickdir
+
+        pos2 = pos1.copy()
+        pos2[:, tickdir] = in_tickdir
+
+        # Batch proj_transform for tick lines
+        x1, y1, _ = proj3d.proj_transform(pos1[:, 0], pos1[:, 1], pos1[:, 2],
+                                          self.axes.M)
+        x2, y2, _ = proj3d.proj_transform(pos2[:, 0], pos2[:, 1], pos2[:, 2],
+                                          self.axes.M)
+
+        # Build label positions
+        labeldeltas = (tick_pads + default_label_offset)[:, np.newaxis] * points
+        pos_label = pos1.copy()
+        pos_label[:, tickdir] = edgep1_tickdir
+        axmask = self._axmask()
+        pos_label = _move_from_center(pos_label, centers, labeldeltas, axmask)
+        lx, ly, _ = proj3d.proj_transform(pos_label[:, 0], pos_label[:, 1],
+                                          pos_label[:, 2], self.axes.M)
+
+        # Update and draw each tick
+        for i, tick in enumerate(ticks):
+            _tick_update_position(tick, (x1[i], x2[i]), (y1[i], y2[i]),
+                                  (lx[i], ly[i]))
             tick.tick1line.set_linewidth(tick_lw[tick._major])
             tick.draw(renderer)
 
@@ -611,38 +631,40 @@ def draw_grid(self, renderer):
         renderer.open_group("grid3d", gid=self.get_gid())
 
         ticks = self._ticks_to_draw
-        if len(ticks):
-            # Get general axis information:
-            info = self._axinfo
-            index = info["i"]
-
-            # Grid lines use data-space bounds (Line3DCollection applies transforms)
-            mins, maxs, tc, highs = self.axes._get_coord_info()
-            bounds = self.axes._get_bounds()
-            xlim, ylim, zlim = bounds[0:2], bounds[2:4], bounds[4:6]
-            data_mins = np.array([xlim[0], ylim[0], zlim[0]])
-            data_maxs = np.array([xlim[1], ylim[1], zlim[1]])
-            minmax = np.where(highs, data_maxs, data_mins)
-            maxmin = np.where(~highs, data_maxs, data_mins)
-
-            # Grid points where the planes meet
-            xyz0 = np.tile(minmax, (len(ticks), 1))
-            xyz0[:, index] = [tick.get_loc() for tick in ticks]
-
-            # Grid lines go from the end of one plane through the plane
-            # intersection (at xyz0) to the end of the other plane.  The first
-            # point (0) differs along dimension index-2 and the last (2) along
-            # dimension index-1.
-            lines = np.stack([xyz0, xyz0, xyz0], axis=1)
-            lines[:, 0, index - 2] = maxmin[index - 2]
-            lines[:, 2, index - 1] = maxmin[index - 1]
-            self.gridlines.set_segments(lines)
-            gridinfo = info['grid']
-            self.gridlines.set_color(gridinfo['color'])
-            self.gridlines.set_linewidth(gridinfo['linewidth'])
-            self.gridlines.set_linestyle(gridinfo['linestyle'])
-            self.gridlines.do_3d_projection()
-            self.gridlines.draw(renderer)
+        if len(ticks) == 0:
+            return
+
+        # Get general axis information:
+        info = self._axinfo
+        index = info["i"]
+
+        # Grid lines use data-space bounds (Line3DCollection applies transforms)
+        mins, maxs, tc, highs = self.axes._get_coord_info()
+        bounds = self.axes._get_bounds()
+        xlim, ylim, zlim = bounds[0:2], bounds[2:4], bounds[4:6]
+        data_mins = np.array([xlim[0], ylim[0], zlim[0]])
+        data_maxs = np.array([xlim[1], ylim[1], zlim[1]])
+        minmax = np.where(highs, data_maxs, data_mins)
+        maxmin = np.where(~highs, data_maxs, data_mins)
+
+        # Grid points where the planes meet
+        xyz0 = np.tile(minmax, (len(ticks), 1))
+        xyz0[:, index] = [tick.get_loc() for tick in ticks]
+
+        # Grid lines go from the end of one plane through the plane
+        # intersection (at xyz0) to the end of the other plane.  The first
+        # point (0) differs along dimension index-2 and the last (2) along
+        # dimension index-1.
+        lines = np.stack([xyz0, xyz0, xyz0], axis=1)
+        lines[:, 0, index - 2] = maxmin[index - 2]
+        lines[:, 2, index - 1] = maxmin[index - 1]
+        self.gridlines.set_segments(lines)
+        gridinfo = info['grid']
+        self.gridlines.set_color(gridinfo['color'])
+        self.gridlines.set_linewidth(gridinfo['linewidth'])
+        self.gridlines.set_linestyle(gridinfo['linestyle'])
+        self.gridlines.do_3d_projection()
+        self.gridlines.draw(renderer)
 
         renderer.close_group('grid3d')
 
