Merge pull request #9418 from Kojoley/win-fix-faulthandler

tacaswell · web-flow · commit b18970d88465 · 2017-10-16T16:04:57.000-04:00
TST: Disable faulthandler on Windows if CPython 3.6-3.6.3
diff --git a/lib/matplotlib/__init__.py b/lib/matplotlib/__init__.py
@@ -1351,7 +1351,14 @@ def _init_tests():
     except ImportError:
         pass
     else:
-        faulthandler.enable()
+        # CPython's faulthandler since v3.6 handles exceptions on Windows
+        # https://bugs.python.org/issue23848 but until v3.6.4 it was
+        # printing non-fatal exceptions https://bugs.python.org/issue30557
+        import platform
+        if not (sys.platform == 'win32' and
+                (3, 6) < sys.version_info < (3, 6, 4) and
+                platform.python_implementation() == 'CPython'):
+            faulthandler.enable()
 
     # The version of FreeType to install locally for running the
     # tests.  This must match the value in `setupext.py`
