Remove extra Py_XDECREF calls

jkseppan · jkseppan · commit b279c150f9a9 · 2014-09-24T07:37:33.000+03:00
Thanks to @mdehoon for catching these!
diff --git a/src/_macosx.m b/src/_macosx.m
@@ -1363,7 +1363,6 @@ static int _transformation_converter(PyObject* object, void* pointer)
         (PyArray_NDIM(facecolors_arr)==1 && PyArray_DIM(facecolors_arr, 0)!=0) ||
         (PyArray_NDIM(facecolors_arr)==2 && PyArray_DIM(facecolors_arr, 1)!=4))
     {
-        Py_XDECREF(facecolors_arr);
         PyErr_SetString(PyExc_ValueError, "Facecolors must by a Nx4 numpy array or empty");
         ok = 0;
         goto exit;
@@ -1377,7 +1376,6 @@ static int _transformation_converter(PyObject* object, void* pointer)
         (PyArray_NDIM(edgecolors_arr)==1 && PyArray_DIM(edgecolors_arr, 0)!=0) ||
         (PyArray_NDIM(edgecolors_arr)==2 && PyArray_DIM(edgecolors_arr, 1)!=4))
     {
-        Py_XDECREF(edgecolors_arr);
         PyErr_SetString(PyExc_ValueError, "Edgecolors must by a Nx4 numpy array or empty");
         ok = 0;
         goto exit;
@@ -1798,7 +1796,6 @@ static int _transformation_converter(PyObject* object, void* pointer)
     if (!coordinates_arr ||
         PyArray_NDIM(coordinates_arr) != 3 || PyArray_DIM(coordinates_arr, 2) != 2)
     {
-        Py_XDECREF(coordinates_arr);
         PyErr_SetString(PyExc_ValueError, "Invalid coordinates array");
         ok = 0;
         goto exit;
@@ -1844,7 +1841,6 @@ static int _transformation_converter(PyObject* object, void* pointer)
         (PyArray_NDIM(facecolors_arr)==1 && PyArray_DIM(facecolors_arr, 0)!=0) ||
         (PyArray_NDIM(facecolors_arr)==2 && PyArray_DIM(facecolors_arr, 1)!=4))
     {
-        Py_XDECREF(facecolors_arr);
         PyErr_SetString(PyExc_ValueError, "facecolors must by a Nx4 numpy array or empty");
         ok = 0;
         goto exit;
@@ -1857,7 +1853,6 @@ static int _transformation_converter(PyObject* object, void* pointer)
         (PyArray_NDIM(edgecolors_arr)==1 && PyArray_DIM(edgecolors_arr, 0)!=0) ||
         (PyArray_NDIM(edgecolors_arr)==2 && PyArray_DIM(edgecolors_arr, 1)!=4))
     {
-        Py_XDECREF(edgecolors_arr);
         PyErr_SetString(PyExc_ValueError, "edgecolors must by a Nx4 numpy array or empty");
         ok = 0;
         goto exit;
