FIX: Add macos timers to the main thread

greglucas · greglucas · commit b2f72f908e58 · 2023-12-15T20:47:05.000-07:00
The macos timers need to be explicitly added to the main runloop
so the drawing takes place there. This causes issues if updating
data from other threads and wanting the plot to update.
diff --git a/src/_macosx.m b/src/_macosx.m
@@ -1726,11 +1726,15 @@ - (void)flagsChanged:(NSEvent *)event
     }
 
     // hold a reference to the timer so we can invalidate/stop it later
-    self->timer = [NSTimer scheduledTimerWithTimeInterval: interval
-                                            repeats: !single
-                                              block: ^(NSTimer *timer) {
+    self->timer = [NSTimer timerWithTimeInterval: interval
+                                         repeats: !single
+                                           block: ^(NSTimer *timer) {
         gil_call_method((PyObject*)self, "_on_timer");
     }];
+    // Schedule the timer on the main run loop which is needed
+    // when updating the UI from a background thread
+    [[NSRunLoop mainRunLoop] addTimer: self->timer forMode: NSRunLoopCommonModes];
+
 exit:
     Py_XDECREF(py_interval);
     Py_XDECREF(py_single);
