Code review

scottshambaugh · scottshambaugh · commit b3ef9b0ff352 · 2022-08-26T08:01:15.000-06:00
diff --git a/doc/api/toolkits/mplot3d/view_angles.rst b/doc/api/toolkits/mplot3d/view_angles.rst
@@ -8,9 +8,9 @@ How to define the view angle
 ============================
 
 The position of the viewport "camera" in a 3D plot is defined by three angles:
-elevation, azimuth, and roll. From the resulting position, it always points
-towards the center of the plot box volume. The angle direction convention is
-shared with
+*elevation*, *azimuth*, and *roll*. From the resulting position, it always
+points towards the center of the plot box volume. The angle direction is a
+common convention, and is shared with
 `PyVista <https://docs.pyvista.org/api/core/camera.html>`_ and
 `MATLAB <https://www.mathworks.com/help/matlab/ref/view.html>`_
 (though MATLAB lacks a roll angle). Note that a positive roll angle rotates the
diff --git a/examples/mplot3d/view_planes_3d.py b/examples/mplot3d/view_planes_3d.py
@@ -16,7 +16,7 @@ def annotate_axes(ax, text, fontsize=18):
     ax.text(x=0.5, y=0.5, z=0.5, s=text,
             va="center", ha="center", fontsize=fontsize, color="black")
 
-# (view, (elev, azim, roll))
+# (plane, (elev, azim, roll))
 views = [('XY',   (90, -90, 0)),
          ('XZ',    (0, -90, 0)),
          ('YZ',    (0,   0, 0)),
@@ -29,18 +29,15 @@ def annotate_axes(ax, text, fontsize=18):
           ['.',   '.', '-XY',   '.']]
 fig, axd = plt.subplot_mosaic(layout, subplot_kw={'projection': '3d'},
                               figsize=(12, 8.5))
-for i in range(len(axd) - 1):
-    plane = views[i][0]
+for plane, angles in views:
     axd[plane].set_xlabel('x')
     axd[plane].set_ylabel('y')
     axd[plane].set_zlabel('z')
     axd[plane].set_proj_type('ortho')
-    axd[plane].view_init(elev=views[i][1][0],
-                         azim=views[i][1][1],
-                         roll=views[i][1][2])
+    axd[plane].view_init(elev=angles[0], azim=angles[1], roll=angles[2])
     axd[plane].set_box_aspect(None, zoom=1.25)
 
-    label = f'{plane}\n{views[i][1]}'
+    label = f'{plane}\n{angles}'
     annotate_axes(axd[plane], label, fontsize=14)
 
 for plane in ('XY', '-XY'):
