Fix no-fill bug introduced in r5976

mdboom · mdboom · commit b59004d7eeab · 2008-08-06T12:50:31.000Z
svn path=/trunk/matplotlib/; revision=5979
diff --git a/lib/matplotlib/axes.py b/lib/matplotlib/axes.py
@@ -5195,26 +5195,14 @@ def hexbin(self, x, y, C = None, gridsize = 100, bins = None,
             ymax = 10**ymax
             self.set_yscale('log')
 
-        class HexagonBinCollection(mcoll.PolyCollection):
-            """A HexagonBinCollection is a PolyCollection where the edge
-               colors are always kept equal to the fill colors"""
-            def update_scalarmappable(self):
-                mcoll.PolyCollection.update_scalarmappable(self)
-                self._edgecolors = self._facecolors
-
         if edgecolors=='none':
-            collection = HexagonBinCollection(
-                        polygons,
-                        linewidths = linewidths,
-                        transOffset = self.transData,
-                        )
-        else:
-            collection = mcoll.PolyCollection(
-                        polygons,
-                        edgecolors = edgecolors,
-                        linewidths = linewidths,
-                        transOffset = self.transData,
-                        )
+            edgecolors = 'face'
+        collection = mcoll.PolyCollection(
+            polygons,
+            edgecolors = edgecolors,
+            linewidths = linewidths,
+            transOffset = self.transData,
+            )
 
         # Transform accum if needed
         if bins=='log':
diff --git a/lib/matplotlib/collections.py b/lib/matplotlib/collections.py
@@ -8,7 +8,7 @@
 they are meant to be fast for common use cases (e.g. a bunch of solid
 line segemnts)
 """
-import math, warnings
+import copy, math, warnings
 import numpy as np
 import numpy.ma as ma
 import matplotlib as mpl
@@ -331,8 +331,8 @@ def set_facecolor(self, c):
         ACCEPTS: matplotlib color arg or sequence of rgba tuples
         """
         if c is None: c = mpl.rcParams['patch.facecolor']
-        self._facecolors = _colors.colorConverter.to_rgba_array(c, self._alpha)
         self._facecolors_original = c
+        self._facecolors = _colors.colorConverter.to_rgba_array(c, self._alpha)
 
     set_facecolors = set_facecolor
 
@@ -361,10 +361,11 @@ def set_edgecolor(self, c):
         """
         if c == 'face':
             self._edgecolors = 'face'
+            self._edgecolors_original = 'face'
         else:
             if c is None: c = mpl.rcParams['patch.edgecolor']
-            self._edgecolors = _colors.colorConverter.to_rgba_array(c, self._alpha)
             self._edgecolors_original = c
+            self._edgecolors = _colors.colorConverter.to_rgba_array(c, self._alpha)
 
     set_edgecolors = set_edgecolor
 
@@ -385,8 +386,9 @@ def set_alpha(self, alpha):
             except (AttributeError, TypeError, IndexError):
                 pass
             try:
-                self._edgecolors = _colors.colorConverter.to_rgba_array(
-                    self._edgecolors_original, self._alpha)
+                if self._edgecolors_original != 'face':
+                    self._edgecolors = _colors.colorConverter.to_rgba_array(
+                        self._edgecolors_original, self._alpha)
             except (AttributeError, TypeError, IndexError):
                 pass
 
@@ -809,7 +811,7 @@ def __init__(self, segments,     # Can be None.
             pickradius=pickradius,
             **kwargs)
 
-        self._facecolors = np.array([])
+        self.set_facecolors([])
         self.set_segments(segments)
 
     def get_paths(self):
diff --git a/lib/matplotlib/colors.py b/lib/matplotlib/colors.py
@@ -332,26 +332,18 @@ def to_rgba_array(self, c, alpha=None):
         if len(c) == 0:
             return np.zeros((0,4), dtype=np.float_)
         try:
-            result = [self.to_rgba(c, alpha)]
+            result = np.array([self.to_rgba(c, alpha)], dtype=np.float_)
         except ValueError:
             # If c is a list it must be maintained as the same list
             # with modified items so that items can be appended to
             # it. This is needed for examples/dynamic_collections.py.
             if isinstance(c, np.ndarray):
                 if len(c.shape) != 2:
                     raise ValueError("Color array must be two-dimensional")
-                if c.shape[1] != 4:
-                    output = np.zeros((c.shape[0], 4))
-                else:
-                    output = c
-            elif not isinstance(c, list):
-                output = list(c)
-            else:
-                output = c
 
+            result = np.zeros((len(c), 4))
             for i, cc in enumerate(c):
-                output[i] = self.to_rgba(cc, alpha)  # change in place
-            result = output
+                result[i] = self.to_rgba(cc, alpha)  # change in place
         return np.asarray(result, np.float_)
 
 colorConverter = ColorConverter()
