Rename more parameters for consistency with superclass method parameter names

ksunden · ksunden · commit b5b34083be86 · 2023-03-30T21:12:05.000-05:00
diff --git a/ci/mypy-stubtest-allowlist.txt b/ci/mypy-stubtest-allowlist.txt
@@ -64,12 +64,7 @@ matplotlib.ticker.MultipleLocator.set_params
 matplotlib.text.Annotation.get_window_extent
 
 # Inconsistent super/sub class parameter name (maybe rename for consistency)
-matplotlib.axis.Axis.set_clip_path
-matplotlib.axis.Tick.set_clip_path
-matplotlib.image.NonUniformImage.set_filternorm
-matplotlib.image.NonUniformImage.set_filterrad
 matplotlib.projections.polar.RadialLocator.nonsingular
-matplotlib.table.Cell.set_transform
 matplotlib.ticker.LogLocator.nonsingular
 matplotlib.ticker.LogitLocator.nonsingular
 
diff --git a/lib/matplotlib/axis.py b/lib/matplotlib/axis.py
@@ -229,10 +229,11 @@ def get_children(self):
                     self.gridline, self.label1, self.label2]
         return children
 
-    def set_clip_path(self, clippath, transform=None):
+    @_api.rename_parameter("3.8", "clippath", "path")
+    def set_clip_path(self, path, transform=None):
         # docstring inherited
-        super().set_clip_path(clippath, transform)
-        self.gridline.set_clip_path(clippath, transform)
+        super().set_clip_path(path, transform)
+        self.gridline.set_clip_path(path, transform)
         self.stale = True
 
     def contains(self, mouseevent):
@@ -1079,10 +1080,11 @@ def _translate_tick_params(kw, reverse=False):
         kwtrans.update(kw_)
         return kwtrans
 
-    def set_clip_path(self, clippath, transform=None):
-        super().set_clip_path(clippath, transform)
+    @_api.rename_parameter("3.8", "clippath", "path")
+    def set_clip_path(self, path, transform=None):
+        super().set_clip_path(path, transform)
         for child in self.majorTicks + self.minorTicks:
-            child.set_clip_path(clippath, transform)
+            child.set_clip_path(path, transform)
         self.stale = True
 
     def get_view_interval(self):
diff --git a/lib/matplotlib/image.py b/lib/matplotlib/image.py
@@ -1188,10 +1188,12 @@ def get_extent(self):
             raise RuntimeError('Must set data first')
         return self._Ax[0], self._Ax[-1], self._Ay[0], self._Ay[-1]
 
-    def set_filternorm(self, s):
+    @_api.rename_parameter("3.8", "s", "filternorm")
+    def set_filternorm(self, filternorm):
         pass
 
-    def set_filterrad(self, s):
+    @_api.rename_parameter("3.8", "s", "filterrad")
+    def set_filterrad(self, filterrad):
         pass
 
     def set_norm(self, norm):
diff --git a/lib/matplotlib/table.py b/lib/matplotlib/table.py
@@ -102,8 +102,9 @@ def __init__(self, xy, width, height, *,
                           text=text, fontproperties=fontproperties,
                           horizontalalignment=loc, verticalalignment='center')
 
-    def set_transform(self, trans):
-        super().set_transform(trans)
+    @_api.rename_parameter("3.8", "trans", "t")
+    def set_transform(self, t):
+        super().set_transform(t)
         # the text does not get the transform!
         self.stale = True
 
