Make stem3d arguments explicit.

QuLogic · QuLogic · commit b809d59d7402 · 2020-12-19T01:06:29.000-05:00
There's no backwards compatibility to worry about, so we don't need to
accept arbitrary positional arguments.
diff --git a/lib/mpl_toolkits/mplot3d/axes3d.py b/lib/mpl_toolkits/mplot3d/axes3d.py
@@ -3288,14 +3288,11 @@ def get_tightbbox(self, renderer, call_axes_locator=True,
                     batch.append(axis_bb)
         return mtransforms.Bbox.union(batch)
 
-    def stem(self, *args, **kwargs):
+    def stem(self, x, y, z, *, linefmt='b-', markerfmt='bo', basefmt='r-',
+             bottom=0, label=None, zdir='z'):
         """
         Create a 3D stem plot.
 
-        Call signatures::
-          stem3(x, y, z, linefmt='b-', markerfmt='bo', basefmt='r-',
-                zdir={'x'|'y'|'z'|'-x'|'-y'})
-
         By default, stem plots vertical lines (using *linefmt*) in the z
         direction at each *x* and *y* location from the baseline to *z*, and
         places a marker there using *markerfmt*. By default, the baseline at
@@ -3322,34 +3319,6 @@ def stem(self, *args, **kwargs):
 
         had_data = self.has_data()
 
-        # Extract the required values
-        x, y, z = [np.asarray(i) for i in args[:3]]
-        args = args[3:]
-
-        # Popping some defaults
-        try:
-            linefmt = kwargs.pop('linefmt', args[0])
-        except IndexError:
-            linefmt = kwargs.pop('linefmt', 'b-')
-        try:
-            markerfmt = kwargs.pop('markerfmt', args[1])
-        except IndexError:
-            markerfmt = kwargs.pop('markerfmt', 'bo')
-        try:
-            basefmt = kwargs.pop('basefmt', args[2])
-        except IndexError:
-            basefmt = kwargs.pop('basefmt', 'r-')
-        try:
-            zdir = kwargs.pop('zdir', args[3])
-        except IndexError:
-            zdir = kwargs.pop('zdir', 'z')
-
-        bottom = kwargs.pop('bottom', None)
-        label = kwargs.pop('label', None)
-
-        if bottom is None:
-            bottom = 0
-
         stemlines = []
         jx, jy, jz = art3d.juggle_axes(x, y, z, zdir)
 
