Fix rubberband in tk.

anntzer · anntzer · commit b9b9f37e4996 · 2020-05-01T22:41:18.000+02:00
The deprecation of NavigationToolbar2.release() used the wrong method
name, causing a needed change in NavigationToolbar2Tk to be missed.
Without this PR, zoom boxes are not erased when the mouse is released.
diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py
@@ -3086,7 +3086,7 @@ def release_zoom(self, event):
 
         self.push_current()
         release = cbook._deprecate_method_override(
-            __class__.press, self, since="3.3", message="Calling an "
+            __class__.release, self, since="3.3", message="Calling an "
             "overridden release() at zoom stop is deprecated since %(since)s "
             "and will be removed %(removal)s; override release_zoom() "
             "instead.")
diff --git a/lib/matplotlib/backends/_backend_tk.py b/lib/matplotlib/backends/_backend_tk.py
@@ -533,7 +533,8 @@ def draw_rubberband(self, event, x0, y0, x1, y1):
             self.canvas._tkcanvas.delete(self.lastrect)
         self.lastrect = self.canvas._tkcanvas.create_rectangle(x0, y0, x1, y1)
 
-    def release(self, event):
+    def release_zoom(self, event):
+        super().release_zoom(event)
         if hasattr(self, "lastrect"):
             self.canvas._tkcanvas.delete(self.lastrect)
             del self.lastrect
