Merge pull request #8513 from ibnIrshad/fix6284_squashed

dstansby · dstansby · commit bad34068c789 · 2017-04-30T20:22:47.000-07:00
Fix autoscaling with twinx and vspans: consider axis with one pair of finite limits ONLY
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -2284,7 +2284,14 @@ def handle_single_axis(scale, autoscaleon, shared_axes, interval,
             # ignore non-finite data limits if good limits exist
             finite_dl = [d for d in dl if np.isfinite(d).all()]
             if len(finite_dl):
+                # if finite limits exist for atleast one axis (and the other is infinite), restore the
+                # finite limits
+                x_finite = [d for d in dl if (np.isfinite(d.intervalx).all() and (d not in finite_dl))]
+                y_finite = [d for d in dl if (np.isfinite(d.intervaly).all() and (d not in finite_dl))]
+
                 dl = finite_dl
+                dl.extend(x_finite)
+                dl.extend(y_finite)
 
             bb = mtransforms.BboxBase.union(dl)
             x0, x1 = getattr(bb, interval)
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -4901,6 +4901,21 @@ def test_minorticks_on():
             ax.minorticks_on()
 
 
+def test_twinx_knows_limits():
+    fig, ax = plt.subplots()
+
+    ax.axvspan(1, 2)
+    xtwin = ax.twinx()
+    xtwin.plot([0, 0.5], [1, 2])
+    # control axis
+    fig2, ax2 = plt.subplots()
+
+    ax2.axvspan(1, 2)
+    ax2.plot([0, 0.5], [1, 2])
+
+    assert((xtwin.viewLim.intervalx == ax2.viewLim.intervalx).all())
+
+
 if __name__ == '__main__':
     import nose
     import sys
