copy all array_view members in copy constructor

jbmohler · jbmohler · commit bae42a8bdee7 · 2014-11-17T12:55:41.000-05:00
diff --git a/src/numpy_cpp.h b/src/numpy_cpp.h
@@ -369,9 +369,11 @@ class array_view : public detail::array_view_accessors<array_view, T, ND>
 
     array_view(const array_view &other, bool contiguous = false) : m_arr(NULL), m_data(NULL)
     {
-        if (!set((PyObject *)other.m_arr)) {
-            throw py::exception();
-        }
+        m_arr = other.m_arr;
+        Py_INCREF(m_arr);
+        m_data = other.m_data;
+        m_shape = other.m_shape;
+        m_strides = other.m_strides;
     }
 
     array_view(PyArrayObject *arr, char *data, npy_intp *shape, npy_intp *strides)

Original file line number	Diff line number	Diff line change
`@@ -369,9 +369,11 @@ class array_view : public detail::array_view_accessors<array_view, T, ND>`
`369`	`369`
`370`	`370`	`array_view(const array_view &other, bool contiguous = false) : m_arr(NULL), m_data(NULL)`
`371`	`371`	`{`
`372`		`- if (!set((PyObject *)other.m_arr)) {`
`373`		`- throw py::exception();`
`374`		`- }`
	`372`	`+ m_arr = other.m_arr;`
	`373`	`+ Py_INCREF(m_arr);`
	`374`	`+ m_data = other.m_data;`
	`375`	`+ m_shape = other.m_shape;`
	`376`	`+ m_strides = other.m_strides;`
`375`	`377`	`}`
`376`	`378`
`377`	`379`	`array_view(PyArrayObject arr, char data, npy_intp shape, npy_intp strides)`