Exceptions should start with a capital letter

timhoffm · timhoffm · commit bc14e50d2b4d · 2019-12-17T22:37:23.000+01:00
diff --git a/examples/specialty_plots/radar_chart.py b/examples/specialty_plots/radar_chart.py
@@ -82,7 +82,7 @@ def _gen_axes_patch(self):
                 return RegularPolygon((0.5, 0.5), num_vars,
                                       radius=.5, edgecolor="k")
             else:
-                raise ValueError("unknown value for 'frame': %s" % frame)
+                raise ValueError("Unknown value for 'frame': %s" % frame)
 
         def _gen_axes_spines(self):
             if frame == 'circle':
@@ -99,7 +99,7 @@ def _gen_axes_spines(self):
                                     + self.transAxes)
                 return {'polar': spine}
             else:
-                raise ValueError("unknown value for 'frame': %s" % frame)
+                raise ValueError("Unknown value for 'frame': %s" % frame)
 
     register_projection(RadarAxes)
     return theta
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -2922,7 +2922,7 @@ def pie(self, x, explode=None, labels=None, colors=None,
             x = np.atleast_1d(x.squeeze())
 
         if np.any(x < 0):
-            raise ValueError("wedge sizes must be non negative values")
+            raise ValueError("Wedge sizes 'x' must be non negative values")
 
         sx = x.sum()
         if sx > 1:
diff --git a/lib/matplotlib/axis.py b/lib/matplotlib/axis.py
@@ -2013,6 +2013,8 @@ def set_ticks_position(self, position):
         ----------
         position : {'top', 'bottom', 'both', 'default', 'none'}
         """
+        cbook._check_in_list(['top', 'bottom', 'both', 'default', 'none'],
+                             position=position)
         if position == 'top':
             self.set_tick_params(which='both', top=True, labeltop=True,
                                  bottom=False, labelbottom=False)
@@ -2032,7 +2034,7 @@ def set_ticks_position(self, position):
                                  bottom=True, labelbottom=True)
             self._tick_position = 'bottom'
         else:
-            raise ValueError("invalid position: %s" % position)
+            assert False, "unhandled parameter not caught by _check_in_list"
         self.stale = True
 
     def tick_top(self):
@@ -2300,6 +2302,8 @@ def set_ticks_position(self, position):
         ----------
         position : {'left', 'right', 'both', 'default', 'none'}
         """
+        cbook._check_in_list(['left', 'right', 'both', 'default', 'none'],
+                             position=position)
         if position == 'right':
             self.set_tick_params(which='both', right=True, labelright=True,
                                  left=False, labelleft=False)
@@ -2318,7 +2322,7 @@ def set_ticks_position(self, position):
             self.set_tick_params(which='both', right=True, labelright=False,
                                  left=True, labelleft=True)
         else:
-            raise ValueError("invalid position: %s" % position)
+            assert False, "unhandled parameter not caught by _check_in_list"
         self.stale = True
 
     def tick_right(self):
diff --git a/lib/matplotlib/cm.py b/lib/matplotlib/cm.py
@@ -229,7 +229,7 @@ def to_rgba(self, x, alpha=None, bytes=False, norm=True):
                 elif x.shape[2] == 4:
                     xx = x
                 else:
-                    raise ValueError("third dimension must be 3 or 4")
+                    raise ValueError("Third dimension must be 3 or 4")
                 if xx.dtype.kind == 'f':
                     if norm and (xx.max() > 1 or xx.min() < 0):
                         raise ValueError("Floating point image RGB values "
diff --git a/lib/matplotlib/dviread.py b/lib/matplotlib/dviread.py
@@ -457,14 +457,14 @@ def _pre(self, i, num, den, mag, k):
         if i != 2:
             raise ValueError("Unknown dvi format %d" % i)
         if num != 25400000 or den != 7227 * 2**16:
-            raise ValueError("nonstandard units in dvi file")
+            raise ValueError("Nonstandard units in dvi file")
             # meaning: TeX always uses those exact values, so it
             # should be enough for us to support those
             # (There are 72.27 pt to an inch so 7227 pt =
             # 7227 * 2**16 sp to 100 in. The numerator is multiplied
             # by 10^5 to get units of 10**-7 meters.)
         if mag != 1000:
-            raise ValueError("nonstandard magnification in dvi file")
+            raise ValueError("Nonstandard magnification in dvi file")
             # meaning: LaTeX seems to frown on setting \mag, so
             # I think we can assume this is constant
         self.state = _dvistate.outer
@@ -653,7 +653,7 @@ def _read(self):
             elif byte == 248:       # postamble (just some number of 248s)
                 break
             else:
-                raise ValueError("unknown vf opcode %d" % byte)
+                raise ValueError("Unknown vf opcode %d" % byte)
 
     def _init_packet(self, pl):
         if self.state != _dvistate.outer:
diff --git a/lib/matplotlib/font_manager.py b/lib/matplotlib/font_manager.py
@@ -901,7 +901,7 @@ def _json_decode(o):
             r.fname = os.path.join(mpl.get_data_path(), r.fname)
         return r
     else:
-        raise ValueError("don't know how to deserialize __class__=%s" % cls)
+        raise ValueError("Don't know how to deserialize __class__=%s" % cls)
 
 
 def json_dump(data, filename):
diff --git a/lib/matplotlib/gridspec.py b/lib/matplotlib/gridspec.py
@@ -225,7 +225,7 @@ def _normalize(key, size, axis):  # Includes last index.
             try:
                 k1, k2 = key
             except ValueError:
-                raise ValueError("unrecognized subplot spec")
+                raise ValueError("Unrecognized subplot spec")
             num1, num2 = np.ravel_multi_index(
                 [_normalize(k1, nrows, 0), _normalize(k2, ncols, 1)],
                 (nrows, ncols))
diff --git a/lib/matplotlib/image.py b/lib/matplotlib/image.py
@@ -1369,7 +1369,7 @@ def get_window_extent(self, renderer=None):
         elif callable(self.bbox):
             return self.bbox(renderer)
         else:
-            raise ValueError("unknown type of bbox")
+            raise ValueError("Unknown type of bbox")
 
     def contains(self, mouseevent):
         """Test whether the mouse event occurred within the image."""
diff --git a/lib/matplotlib/patches.py b/lib/matplotlib/patches.py
@@ -3991,7 +3991,7 @@ def __init__(self, posA=None, posB=None,
         elif posA is None and posB is None and path is not None:
             self._posA_posB = None
         else:
-            raise ValueError("either posA and posB, or path need to provided")
+            raise ValueError("Either posA and posB, or path need to provided")
 
         self.patchA = patchA
         self.patchB = patchB
diff --git a/lib/matplotlib/sphinxext/plot_directive.py b/lib/matplotlib/sphinxext/plot_directive.py
@@ -178,7 +178,7 @@ def _option_boolean(arg):
 def _option_context(arg):
     if arg in [None, 'reset', 'close-figs']:
         return arg
-    raise ValueError("argument should be None or 'reset' or 'close-figs'")
+    raise ValueError("Argument should be None or 'reset' or 'close-figs'")
 
 
 def _option_format(arg):
diff --git a/lib/matplotlib/tests/test_ticker.py b/lib/matplotlib/tests/test_ticker.py
@@ -865,7 +865,7 @@ def logit_deformatter(string):
         if match:
             num, deno = float(match["num"]), float(match["deno"])
             return num / deno
-        raise ValueError("not formatted by LogitFormatter")
+        raise ValueError("Not formatted by LogitFormatter")
 
     @pytest.mark.parametrize(
         "fx, x",
diff --git a/lib/mpl_toolkits/axisartist/grid_finder.py b/lib/mpl_toolkits/axisartist/grid_finder.py
@@ -204,7 +204,7 @@ def update(self, **kw):
                      "tick_formatter2"]:
                 setattr(self, k, kw[k])
             else:
-                raise ValueError("unknown update property '%s'" % k)
+                raise ValueError("Unknown update property '%s'" % k)
 
 
 @cbook.deprecated("3.2")
