another attempt; add a test

ResidentMario · ResidentMario · commit c23e5f60ab49 · 2017-03-10T13:58:26.000-05:00
diff --git a/lib/matplotlib/tests/test_tightlayout.py b/lib/matplotlib/tests/test_tightlayout.py
@@ -148,6 +148,7 @@ def test_tight_layout7():
     ax.set_title('Right Title', loc='right', fontsize=fontsize)
     plt.tight_layout()
 
+
 @image_comparison(baseline_images=['tight_layout8'])
 def test_tight_layout8():
     'Test automatic use of tight_layout'
@@ -157,6 +158,15 @@ def test_tight_layout8():
     example_plot(ax, fontsize=24)
 
 
+@image_comparison(baseline_images=['tight_layout9'])
+def test_tight_layout9():
+    # Test tight_layout for non-visible suplots
+    # GH 8244
+    f, axarr = plt.subplots(2, 2)
+    axarr[1][1].set_visible(False)
+    plt.tight_layout()
+
+
 # The following test is misleading when the text is removed.
 @image_comparison(baseline_images=['outward_ticks'], remove_text=False)
 def test_outward_ticks():
diff --git a/lib/matplotlib/tight_layout.py b/lib/matplotlib/tight_layout.py
@@ -123,7 +123,10 @@ def auto_adjust_subplotpars(fig, renderer,
     for subplots, ax_bbox, (num1, num2) in zip(subplot_list,
                                                ax_bbox_list,
                                                num1num2_list):
-        tight_bbox_raw = union([ax.get_tightbbox(renderer) for ax in subplots if ax.get_visible()])
+        if all([not ax.get_visible() for ax in subplots]):
+            continue
+
+        tight_bbox_raw = union([ax.get_tightbbox(renderer) for ax in subplots])
         tight_bbox = TransformedBbox(tight_bbox_raw,
                                      fig.transFigure.inverted())
 
