fixed a bug where annotations w/ arrows were not getting the figure instance set properly

jdh2358 · jdh2358 · commit c379aae7b481 · 2008-01-31T17:46:56.000Z
svn path=/trunk/matplotlib/; revision=4913
diff --git a/lib/matplotlib/lines.py b/lib/matplotlib/lines.py
@@ -169,12 +169,14 @@ class Line2D(Artist):
     def __str__(self):
         if self._label != "":
             return "Line2D(%s)"%(self._label)
-        elif len(self._x) > 3:
+        elif hasattr(self, '_x') and len(self._x) > 3:
             return "Line2D((%g,%g),(%g,%g),...,(%g,%g))"\
                 %(self._x[0],self._y[0],self._x[0],self._y[0],self._x[-1],self._y[-1])
-        else:
+        elif hasattr(self, '_x'):
             return "Line2D(%s)"\
                 %(",".join(["(%g,%g)"%(x,y) for x,y in zip(self._x,self._y)]))
+        else:
+            return "Line2D()"
 
     def __init__(self, xdata, ydata,
                  linewidth       = None, # all Nones default to rc
diff --git a/lib/matplotlib/mlab.py b/lib/matplotlib/mlab.py
@@ -84,7 +84,7 @@
 """
 
 from __future__ import division
-import csv, warnings
+import csv, warnings, copy
 
 import numpy as npy
 
@@ -2186,7 +2186,12 @@ def get_converters(reader):
     # Get header and remove invalid characters
     needheader = names is None
     if needheader:
-        headers = reader.next()
+        for row in reader:
+            if len(row) and row[0].startswith(comments):
+                continue
+            headers = row
+            break
+
         # remove these chars
         delete = set("""~!@#$%^&*()-=+~\|]}[{';: /?.>,<""")
         delete.add('"')
diff --git a/lib/matplotlib/rcsetup.py b/lib/matplotlib/rcsetup.py
@@ -425,12 +425,12 @@ def __call__(self, s):
     'figure.facecolor'  : [ '0.75', validate_color], # facecolor; scalar gray
     'figure.edgecolor'  : [ 'w', validate_color],  # edgecolor; white
 
-    'figure.subplot.left'   : [0.125, ValidateInterval(0, 1, closedmin=False, closedmax=False)],
-    'figure.subplot.right'  : [0.9, ValidateInterval(0, 1, closedmin=False, closedmax=False)],
-    'figure.subplot.bottom' : [0.1, ValidateInterval(0, 1, closedmin=False, closedmax=False)],
-    'figure.subplot.top'    : [0.9, ValidateInterval(0, 1, closedmin=False, closedmax=False)],
-    'figure.subplot.wspace' : [0.2, ValidateInterval(0, 1, closedmin=False, closedmax=True)],
-    'figure.subplot.hspace' : [0.2, ValidateInterval(0, 1, closedmin=False, closedmax=True)],
+    'figure.subplot.left'   : [0.125, ValidateInterval(0, 1, closedmin=True, closedmax=True)],
+    'figure.subplot.right'  : [0.9, ValidateInterval(0, 1, closedmin=True, closedmax=True)],
+    'figure.subplot.bottom' : [0.1, ValidateInterval(0, 1, closedmin=True, closedmax=True)],
+    'figure.subplot.top'    : [0.9, ValidateInterval(0, 1, closedmin=True, closedmax=True)],
+    'figure.subplot.wspace' : [0.2, ValidateInterval(0, 1, closedmin=True, closedmax=False)],
+    'figure.subplot.hspace' : [0.2, ValidateInterval(0, 1, closedmin=True, closedmax=False)],
 
     'figure.autolayout'   : [False, validate_bool],
 
diff --git a/lib/matplotlib/text.py b/lib/matplotlib/text.py
@@ -1052,6 +1052,12 @@ def contains(self,event):
         return t,tinfo
 
 
+    def set_figure(self, fig):
+
+        if self.arrow is not None:
+            self.arrow.set_figure(fig)
+        Artist.set_figure(self, fig)
+
     def set_clip_box(self, clipbox):
         """
         Set the artist's clip Bbox
@@ -1204,6 +1210,8 @@ def draw(self, renderer):
         self.update_positions(renderer)
 
         if self.arrow is not None:
+            if self.arrow.figure is None and self.figure is not None:
+                self.arrow.figure = self.figure
             self.arrow.draw(renderer)
 
         Text.draw(self, renderer)
