FIX: cross figure legends with patches

tacaswell · tacaswell · commit ca2f49ac9e9d · 2016-04-29T23:24:56.000-04:00
Found via biocore/qiime#2117 The `update_props` method on `Patch` was setting the figure along with the style. This was setting the new patch for the legend to have the same figure as the original handle, but this is later attempted to be set to the figure the legend is in when the patch is added to the legend. This fix should not break anything as if the patch is going to be drawn it should be added to the draw tree which _should_ in turn set the correct figure.
diff --git a/lib/matplotlib/patches.py b/lib/matplotlib/patches.py
@@ -179,7 +179,6 @@ def update_from(self, other):
         self.set_linewidth(other.get_linewidth())
         self.set_linestyle(other.get_linestyle())
         self.set_transform(other.get_data_transform())
-        self.set_figure(other.get_figure())
         self.set_alpha(other.get_alpha())
 
     def get_extents(self):
diff --git a/lib/matplotlib/tests/test_legend.py b/lib/matplotlib/tests/test_legend.py
@@ -240,6 +240,15 @@ def test_legend_stackplot():
     ax.legend(loc=0)
 
 
+@cleanup
+def test_cross_figure_patch_legend():
+    fig, ax = plt.subplots()
+    fig2, ax2 = plt.subplots()
+
+    brs = ax.bar(range(3), range(3))
+    fig2.legend(brs, 'foo')
+
+
 @cleanup
 def test_nanscatter():
     fig, ax = plt.subplots()
