MNT: Remove unnecessary scalar mappable updates

greglucas · greglucas · commit ce016e2d8f10 · 2021-05-24T20:14:52.000-06:00
Remove the extra calls to self.changed() in scalar mappable
that are already handled by the callbacks attached to the norm.
diff --git a/lib/matplotlib/cm.py b/lib/matplotlib/cm.py
@@ -418,6 +418,8 @@ def set_clim(self, vmin=None, vmax=None):
 
              .. ACCEPTS: (vmin: float, vmax: float)
         """
+        # If the norm's limits are updated self.changed() will be called
+        # through the callbacks attached to the norm
         if vmax is None:
             try:
                 vmin, vmax = vmin
@@ -427,7 +429,6 @@ def set_clim(self, vmin=None, vmax=None):
             self.norm.vmin = colors._sanitize_extrema(vmin)
         if vmax is not None:
             self.norm.vmax = colors._sanitize_extrema(vmax)
-        self.changed()
 
     def get_alpha(self):
         """
@@ -482,8 +483,9 @@ def autoscale(self):
         """
         if self._A is None:
             raise TypeError('You must first set_array for mappable')
+        # If the norm's limits are updated self.changed() will be called
+        # through the callbacks attached to the norm
         self.norm.autoscale(self._A)
-        self.changed()
 
     def autoscale_None(self):
         """
@@ -492,7 +494,7 @@ def autoscale_None(self):
         """
         if self._A is None:
             raise TypeError('You must first set_array for mappable')
-        # If the norm updates the limits *self.changed()* will be called
+        # If the norm's limits are updated self.changed() will be called
         # through the callbacks attached to the norm
         self.norm.autoscale_None(self._A)
 
