Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit d17cc1c

Browse files
committed
ci: Ensure minimum version builds are really constrained.
On Travis, NumPy was already installed and happened to be 1.16.4, roundabout our desired minimum version. On GitHub Actions, NumPy is not installed and gets installed later, since it was never specified in the command with the pins. Also, add minimum Pillow to the pins.
1 parent 6ff5d48 commit d17cc1c

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

.github/workflows/tests.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ jobs:
100100
101101
# Install dependencies from PyPI.
102102
python -mpip install --upgrade $PRE \
103+
cycler kiwisolver numpy pillow pyparsing python-dateutil \
103104
-r requirements/testing/travis_all.txt \
104105
${{ matrix.extra-requirements }}
105106
@@ -154,7 +155,9 @@ jobs:
154155
export CPPFLAGS=--coverage
155156
fi
156157
157-
python -mpip install -e .
158+
# All dependencies must have been pre-installed, so that the minver
159+
# constraints are held.
160+
python -mpip install --no-deps -e .
158161
159162
if [[ "${{ runner.os }}" != 'macOS' ]]; then
160163
unset CPPFLAGS

requirements/testing/minver.txt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
# Extra pip requirements for the minimum-version travis run
1+
# Extra pip requirements for the minimum-version CI run
22

33
cycler==0.10
4-
python-dateutil==2.7
4+
kiwisolver==1.0.1
55
numpy==1.16.0
6+
pillow==6.2.0
67
pyparsing==2.2.1
7-
kiwisolver==1.0.1
8+
python-dateutil==2.7

0 commit comments

Comments
 (0)