Don't try to cleanup CallbackRegistry during interpreter shutd… (#14843)

anntzer · web-flow · commit d1941a713f6b · 2019-07-22T09:42:47.000+02:00
Don't try to cleanup CallbackRegistry during interpreter shutdown.
diff --git a/lib/matplotlib/cbook/__init__.py b/lib/matplotlib/cbook/__init__.py
@@ -152,7 +152,12 @@ def connect(self, s, func):
         self.callbacks[s][cid] = proxy
         return cid
 
-    def _remove_proxy(self, proxy):
+    # Keep a reference to sys.is_finalizing, as sys may have been cleared out
+    # at that point.
+    def _remove_proxy(self, proxy, *, _is_finalizing=sys.is_finalizing):
+        if _is_finalizing():
+            # Weakrefs can't be properly torn down at that point anymore.
+            return
         for signal, proxies in list(self._func_cid_map.items()):
             try:
                 del self.callbacks[signal][proxies[proxy]]
