BUG: fix normalizing image data contained in np.ndarray subclass

neutrinoceros · neutrinoceros · commit d337f6900ae6 · 2024-01-22T20:28:52.000+01:00
diff --git a/lib/matplotlib/image.py b/lib/matplotlib/image.py
@@ -461,12 +461,12 @@ def _make_image(self, A, in_bbox, out_bbox, clip_bbox, magnification=1.0,
                 vmid = np.float64(self.norm.vmin) + dv / 2
                 fact = 1e7 if scaled_dtype == np.float64 else 1e4
                 newmin = vmid - dv * fact
-                if newmin < a_min:
+                if newmin < np.float64(a_min):
                     newmin = None
                 else:
                     a_min = np.float64(newmin)
                 newmax = vmid + dv * fact
-                if newmax > a_max:
+                if newmax > np.float64(a_max):
                     newmax = None
                 else:
                     a_max = np.float64(newmax)
diff --git a/lib/matplotlib/tests/test_colorbar.py b/lib/matplotlib/tests/test_colorbar.py
@@ -1238,3 +1238,48 @@ def test_colorbar_format_string_and_old():
     plt.imshow([[0, 1]])
     cb = plt.colorbar(format="{x}%")
     assert isinstance(cb._formatter, StrMethodFormatter)
+
+
+def test_colorbar_log_units():
+    class FakeQuantity(np.ndarray):
+        # this is a self-contained version of astropy.units.Quantity
+        # reduced to a bare minimum to reproduce
+        # https://github.com/astropy/astropy/issues/11306
+
+        def __new__(cls, value):
+            return np.array(value).view(cls)
+
+        def __array_ufunc__(self, function, method, *inputs, **kwargs):
+            def to_value(q):
+                value = q.view(np.ndarray)
+                if value.shape:
+                    return value
+                else:
+                    return value[()]
+
+            arrays = [to_value(q) for q in inputs]
+            result = super().__array_ufunc__(function, method, *arrays, **kwargs)
+            if function not in (np.minimum, np.maximum):
+                return result
+            else:
+                return self._new_view(result)
+
+        def _new_view(self, obj):
+            obj = np.array(obj, copy=False, subok=True)
+            view = obj.view(FakeQuantity)
+            return view
+
+        def __ne__(self, other):
+            return NotImplemented
+
+        def __float__(self):
+            raise RuntimeError("boom")
+
+        def item(self, *args):
+            return self._new_view(super().item(*args))
+
+    data = FakeQuantity([[1, 2], [3, 4]])
+    fig, ax = plt.subplots()
+    im = ax.imshow(data, norm=LogNorm())
+    fig.colorbar(im)
+    fig.canvas.draw()
diff --git a/lib/matplotlib/transforms.py b/lib/matplotlib/transforms.py
@@ -2853,15 +2853,15 @@ def nonsingular(vmin, vmax, expander=0.001, tiny=1e-15, increasing=True):
     if (not np.isfinite(vmin)) or (not np.isfinite(vmax)):
         return -expander, expander
 
+    # Expand vmin, vmax to float: if they were integer types, they can wrap
+    # around in abs (abs(np.int8(-128)) == -128) and vmax - vmin can overflow.
+    vmin, vmax = map(np.float64, (vmin, vmax))
+
     swapped = False
     if vmax < vmin:
         vmin, vmax = vmax, vmin
         swapped = True
 
-    # Expand vmin, vmax to float: if they were integer types, they can wrap
-    # around in abs (abs(np.int8(-128)) == -128) and vmax - vmin can overflow.
-    vmin, vmax = map(float, [vmin, vmax])
-
     maxabsvalue = max(abs(vmin), abs(vmax))
     if maxabsvalue < (1e6 / tiny) * np.finfo(float).tiny:
         vmin = -expander
