More review comments

rth · rth · commit d376dad7dc1c · 2019-01-22T16:42:00.000+01:00
diff --git a/lib/matplotlib/hatch.py b/lib/matplotlib/hatch.py
@@ -170,7 +170,7 @@ def __init__(self, hatch, density):
         path = Path.unit_regular_star(5)
         self.shape_vertices = path.vertices
         self.shape_codes = np.full(len(self.shape_vertices), Path.LINETO,
-                                   dtype=np.int32)
+                                   dtype=Path.code_type)
         self.shape_codes[0] = Path.MOVETO
         Shapes.__init__(self, hatch, density)
 
diff --git a/lib/matplotlib/legend_handler.py b/lib/matplotlib/legend_handler.py
@@ -231,7 +231,7 @@ def create_artists(self, legend, orig_handle,
         xdata, xdata_marker = self.get_xdata(legend, xdescent, ydescent,
                                              width, height, fontsize)
 
-        ydata = np.full(xdata.shape, ((height - ydescent) / 2), float)
+        ydata = np.full_like(xdata, ((height - ydescent) / 2))
         legline = Line2D(xdata, ydata)
 
         self.update_prop(legline, orig_handle, legend)
diff --git a/lib/matplotlib/path.py b/lib/matplotlib/path.py
@@ -552,7 +552,7 @@ def interpolated(self, steps):
         vertices = simple_linear_interpolation(self.vertices, steps)
         codes = self.codes
         if codes is not None:
-            new_codes = np.full(((len(codes) - 1) * steps + 1, ), Path.LINETO,
+            new_codes = np.full((len(codes) - 1) * steps + 1, Path.LINETO,
                                 dtype=self.code_type)
             new_codes[0::steps] = codes
         else:
@@ -865,7 +865,7 @@ def arc(cls, theta1, theta2, n=None, is_wedge=False):
         if is_wedge:
             length = n * 3 + 4
             vertices = np.zeros((length, 2), float)
-            codes = np.full((length, ), cls.CURVE4, dtype=cls.code_type)
+            codes = np.full(length, cls.CURVE4, dtype=cls.code_type)
             vertices[1] = [xA[0], yA[0]]
             codes[0:2] = [cls.MOVETO, cls.LINETO]
             codes[-2:] = [cls.LINETO, cls.CLOSEPOLY]
@@ -874,7 +874,7 @@ def arc(cls, theta1, theta2, n=None, is_wedge=False):
         else:
             length = n * 3 + 1
             vertices = np.empty((length, 2), float)
-            codes = np.full((length, ), cls.CURVE4, dtype=cls.code_type)
+            codes = np.full(length, cls.CURVE4, dtype=cls.code_type)
             vertices[0] = [xA[0], yA[0]]
             codes[0] = cls.MOVETO
             vertex_offset = 1
diff --git a/lib/matplotlib/tri/trirefine.py b/lib/matplotlib/tri/trirefine.py
@@ -238,12 +238,8 @@ def _refine_triangulation_once(triangulation, ancestors=None):
         # (can be -1 if border edge)
         # For slave and master we will identify the apex pointing to the edge
         # start
-        edge_elems = np.ravel(np.vstack([np.arange(ntri, dtype=np.int32),
-                                         np.arange(ntri, dtype=np.int32),
-                                         np.arange(ntri, dtype=np.int32)]))
-        edge_apexes = np.ravel(np.vstack([np.zeros(ntri, dtype=np.int32),
-                                          np.ones(ntri, dtype=np.int32),
-                                          np.full(ntri, 2, dtype=np.int32)]))
+        edge_elems = np.tile(np.arange(3, dtype=np.int32), ntri)
+        edge_apexes = np.repeat(np.arange(3, dtype=np.int32), ntri)
         edge_neighbors = neighbors[edge_elems, edge_apexes]
         mask_masters = (edge_elems > edge_neighbors)
 
