Test GUI

oscargus · oscargus · commit d7386561971c · 2023-06-04T13:37:59.000+02:00
diff --git a/lib/matplotlib/tests/test_backend_tk.py b/lib/matplotlib/tests/test_backend_tk.py
@@ -158,7 +158,6 @@ def target():
     thread.join()
 
 
-@pytest.mark.backend('TkAgg', skip_on_importerror=True)
 @pytest.mark.flaky(reruns=3)
 @_isolated_tk_test(success_count=0)
 def test_never_update():
@@ -199,7 +198,6 @@ class Toolbar(NavigationToolbar2Tk):
     print("success")
 
 
-@pytest.mark.backend('TkAgg', skip_on_importerror=True)
 @_isolated_tk_test(success_count=1)
 def test_canvas_focus():
     import tkinter as tk
diff --git a/lib/matplotlib/tests/test_backends_interactive.py b/lib/matplotlib/tests/test_backends_interactive.py
@@ -107,7 +107,8 @@ def _test_interactive_impl():
     import io
     import json
     import sys
-    from unittest import TestCase
+
+    import pytest
 
     import matplotlib as mpl
     from matplotlib import pyplot as plt
@@ -119,8 +120,6 @@ def _test_interactive_impl():
 
     mpl.rcParams.update(json.loads(sys.argv[1]))
     backend = plt.rcParams["backend"].lower()
-    assert_equal = TestCase().assertEqual
-    assert_raises = TestCase().assertRaises
 
     if backend.endswith("agg") and not backend.startswith(("gtk", "web")):
         # Force interactive framework setup.
@@ -135,25 +134,25 @@ def _test_interactive_impl():
         # uses no interactive framework).
 
         if backend != "tkagg":
-            with assert_raises(ImportError):
+            with pytest.raises(ImportError):
                 mpl.use("tkagg", force=True)
 
         def check_alt_backend(alt_backend):
             mpl.use(alt_backend, force=True)
             fig = plt.figure()
-            assert_equal(
-                type(fig.canvas).__module__,
-                f"matplotlib.backends.backend_{alt_backend}")
+            assert (type(fig.canvas).__module__ ==
+                    f"matplotlib.backends.backend_{alt_backend}")
 
         if importlib.util.find_spec("cairocffi"):
             check_alt_backend(backend[:-3] + "cairo")
         check_alt_backend("svg")
     mpl.use(backend, force=True)
 
     fig, ax = plt.subplots()
-    assert_equal(
-        type(fig.canvas).__module__,
-        f"matplotlib.backends.backend_{backend}")
+    assert type(fig.canvas).__module__ == f"matplotlib.backends.backend_{backend}"
+
+    if backend != "webagg":
+        assert fig.canvas.manager.get_window_title() == "Figure 1"
 
     if mpl.rcParams["toolbar"] == "toolmanager":
         # test toolbar button icon LA mode see GH issue 25174
@@ -164,8 +163,6 @@ def check_alt_backend(alt_backend):
         _test_toolbar_button_la_mode_icon(fig)
 
     ax.plot([0, 1], [2, 3])
-    if fig.canvas.toolbar:  # i.e toolbar2.
-        fig.canvas.toolbar.draw_rubberband(None, 1., 1, 2., 2)
 
     timer = fig.canvas.new_timer(1.)  # Test that floats are cast to int.
     timer.add_callback(KeyEvent("key_press_event", fig.canvas, "q")._process)
@@ -176,6 +173,10 @@ def check_alt_backend(alt_backend):
     result = io.BytesIO()
     fig.savefig(result, format='png')
 
+    if fig.canvas.toolbar:  # i.e toolbar2.
+        fig.canvas.toolbar.draw_rubberband(None, 1., 1, 2., 2)
+        fig.canvas.toolbar.remove_rubberband()
+
     plt.show()
 
     # Ensure that the window is really closed.
@@ -189,7 +190,7 @@ def check_alt_backend(alt_backend):
     if not backend.startswith('qt5') and sys.platform == 'darwin':
         # FIXME: This should be enabled everywhere once Qt5 is fixed on macOS
         # to not resize incorrectly.
-        assert_equal(result.getvalue(), result_after.getvalue())
+        assert result.getvalue() == result_after.getvalue()
 
 
 @pytest.mark.parametrize("env", _get_testable_interactive_backends())
@@ -241,7 +242,7 @@ def _test_thread_impl():
     future.result()  # Joins the thread; rethrows any exception.
     plt.close()  # backend is responsible for flushing any events here
     if plt.rcParams["backend"].startswith("WX"):
-        # TODO: debug why WX needs this only on py3.8
+        # TODO: debug why WX needs this only on py >= 3.8
         fig.canvas.flush_events()
 
 
