Make _warn_external correctly report warnings arising from tests.

anntzer · anntzer · commit d7726a303a3b · 2019-04-11T11:17:10.000+02:00
Before the PR: ``` $ pytest lib/matplotlib/tests/test_cbook.py::test_is_hashable <elided> lib/matplotlib/tests/test_cbook.py::test_is_hashable .../site-packages/_pytest/python.py:166: MatplotlibDeprecationWarning: The is_hashable function was deprecated in Matplotlib 3.1 and will be removed in 3.3. Use isinstance(..., collections.abc.Hashable) instead. testfunction(**testargs) -- Docs: https://docs.pytest.org/en/latest/warnings.html ``` After ``` $ pytest lib/matplotlib/tests/test_cbook.py::test_is_hashable <elided> lib/matplotlib/tests/test_cbook.py::test_is_hashable .../lib/matplotlib/tests/test_cbook.py:22: MatplotlibDeprecationWarning: The is_hashable function was deprecated in Matplotlib 3.1 and will be removed in 3.3. Use isinstance(..., collections.abc.Hashable) instead. assert cbook.is_hashable(s) lib/matplotlib/tests/test_cbook.py::test_is_hashable .../lib/matplotlib/tests/test_cbook.py:25: MatplotlibDeprecationWarning: The is_hashable function was deprecated in Matplotlib 3.1 and will be removed in 3.3. Use isinstance(..., collections.abc.Hashable) instead. assert not cbook.is_hashable(lst) ```
diff --git a/lib/matplotlib/cbook/__init__.py b/lib/matplotlib/cbook/__init__.py
@@ -2041,7 +2041,7 @@ def _warn_external(message, category=None):
         if frame is None:
             # when called in embedded context may hit frame is None
             break
-        if not re.match(r"\A(matplotlib|mpl_toolkits)(\Z|\.)",
+        if not re.match(r"\A(matplotlib|mpl_toolkits)(\Z|\.(?!tests\.))",
                         # Work around sphinx-gallery not setting __name__.
                         frame.f_globals.get("__name__", "")):
             break
diff --git a/lib/matplotlib/tests/test_cbook.py b/lib/matplotlib/tests/test_cbook.py
@@ -560,3 +560,9 @@ def func(pre, arg, post=None):
         func(1, 2)
     with pytest.warns(MatplotlibDeprecationWarning):
         func(1, 2, 3)
+
+
+def test_warn_external(recwarn):
+    cbook._warn_external("oops")
+    assert len(recwarn) == 1
+    assert recwarn[0].filename == __file__
