Fix incorrect text line spacing. (#8495)

Keerush · tacaswell · commit d9305035ea98 · 2017-04-17T15:31:29.000-04:00
Fixed issue with line spacing being ignored by text closes #7523
diff --git a/lib/matplotlib/tests/test_text.py b/lib/matplotlib/tests/test_text.py
@@ -421,3 +421,24 @@ def test_font_scaling():
 
     for i, fs in enumerate(range(4, 43, 2)):
         ax.text(0.1, i*30, "{fs} pt font size".format(fs=fs), fontsize=fs)
+
+
+@pytest.mark.parametrize('spacing1, spacing2', [(0.4, 2), (2, 0.4), (2, 2)])
+def test_two_2line_texts(spacing1, spacing2):
+    text_string = 'line1\nline2'
+    fig = plt.figure()
+    renderer = fig.canvas.get_renderer()
+
+    text1 = plt.text(0.25, 0.5, text_string, linespacing=spacing1)
+    text2 = plt.text(0.25, 0.5, text_string, linespacing=spacing2)
+    fig.canvas.draw()
+
+    box1 = text1.get_window_extent(renderer=renderer)
+    box2 = text2.get_window_extent(renderer=renderer)
+
+    # line spacing only affects height
+    assert box1.width == box2.width
+    if (spacing1 == spacing2):
+        assert box1.height == box2.height
+    else:
+        assert box1.height != box2.height
diff --git a/lib/matplotlib/text.py b/lib/matplotlib/text.py
@@ -912,6 +912,7 @@ def get_prop_tup(self, renderer=None):
                 hash(self._fontproperties),
                 self._rotation, self._rotation_mode,
                 self.figure.dpi, id(renderer or self._renderer),
+                self._linespacing
                 )
 
     def get_text(self):

Original file line number	Diff line number	Diff line change
`@@ -912,6 +912,7 @@ def get_prop_tup(self, renderer=None):`
`912`	`912`	`hash(self._fontproperties),`
`913`	`913`	`self._rotation, self._rotation_mode,`
`914`	`914`	`self.figure.dpi, id(renderer or self._renderer),`
	`915`	`+ self._linespacing`
`915`	`916`	`)`
`916`	`917`
`917`	`918`	`def get_text(self):`