Construct events with kwargs in macosx.

anntzer · anntzer · commit d947ff4153a8 · 2022-07-22T18:55:08.000+02:00
diff --git a/src/_macosx.m b/src/_macosx.m
@@ -254,19 +254,30 @@ static void gil_call_method(PyObject* obj, const char* name)
     PyGILState_Release(gstate);
 }
 
-#define PROCESS_EVENT(cls_name, fmt, ...) \
-{ \
-    PyGILState_STATE gstate = PyGILState_Ensure(); \
-    PyObject* module = NULL, * event = NULL, * result = NULL; \
-    if (!(module = PyImport_ImportModule("matplotlib.backend_bases")) \
-        || !(event = PyObject_CallMethod(module, cls_name, fmt, __VA_ARGS__)) \
-        || !(result = PyObject_CallMethod(event, "_process", ""))) { \
-        PyErr_Print(); \
-    } \
-    Py_XDECREF(module); \
-    Py_XDECREF(event); \
-    Py_XDECREF(result); \
-    PyGILState_Release(gstate); \
+void process_event(char const* cls_name, char const* fmt, ...)
+{
+    PyGILState_STATE gstate = PyGILState_Ensure();
+    PyObject* module = NULL, * cls = NULL,
+            * args = NULL, * kwargs = NULL,
+            * event = NULL, * result = NULL;
+    va_list argp;
+    va_start(argp, fmt);
+    if (!(module = PyImport_ImportModule("matplotlib.backend_bases"))
+        || !(cls = PyObject_GetAttrString(module, cls_name))
+        || !(args = PyTuple_New(0))
+        || !(kwargs = Py_VaBuildValue(fmt, argp))
+        || !(event = PyObject_Call(cls, args, kwargs))
+        || !(result = PyObject_CallMethod(event, "_process", ""))) {
+        PyErr_Print();
+    }
+    va_end(argp);
+    Py_XDECREF(module);
+    Py_XDECREF(cls);
+    Py_XDECREF(args);
+    Py_XDECREF(kwargs);
+    Py_XDECREF(event);
+    Py_XDECREF(result);
+    PyGILState_Release(gstate);
 }
 
 static bool backend_inited = false;
@@ -1352,7 +1363,9 @@ - (void)windowDidResize: (NSNotification*)notification
 
 - (void)windowWillClose:(NSNotification*)notification
 {
-    PROCESS_EVENT("CloseEvent", "sO", "close_event", canvas);
+    process_event(
+        "CloseEvent", "{s:s, s:O}",
+        "name", "close_event", "canvas", canvas);
 }
 
 - (BOOL)windowShouldClose:(NSNotification*)notification
@@ -1383,7 +1396,9 @@ - (void)mouseEntered:(NSEvent *)event
     location = [self convertPoint: location fromView: nil];
     x = location.x * device_scale;
     y = location.y * device_scale;
-    PROCESS_EVENT("LocationEvent", "sOii", "figure_enter_event", canvas, x, y);
+    process_event(
+        "LocationEvent", "{s:s, s:O, s:i, s:i}",
+        "name", "figure_enter_event", "canvas", canvas, "x", x, "y", y);
 }
 
 - (void)mouseExited:(NSEvent *)event
@@ -1393,7 +1408,9 @@ - (void)mouseExited:(NSEvent *)event
     location = [self convertPoint: location fromView: nil];
     x = location.x * device_scale;
     y = location.y * device_scale;
-    PROCESS_EVENT("LocationEvent", "sOii", "figure_leave_event", canvas, x, y);
+    process_event(
+        "LocationEvent", "{s:s, s:O, s:i, s:i}",
+        "name", "figure_leave_event", "canvas", canvas, "x", x, "y", y);
 }
 
 - (void)mouseDown:(NSEvent *)event
@@ -1429,8 +1446,10 @@ - (void)mouseDown:(NSEvent *)event
     if ([event clickCount] == 2) {
       dblclick = 1;
     }
-    PROCESS_EVENT("MouseEvent", "sOiiiOii", "button_press_event", canvas,
-                  x, y, num, Py_None /* key */, 0 /* step */, dblclick);
+    process_event(
+        "MouseEvent", "{s:s, s:O, s:i, s:i, s:i, s:i}",
+        "name", "button_press_event", "canvas", canvas, "x", x, "y", y,
+        "num", num, "dblclick", dblclick);
 }
 
 - (void)mouseUp:(NSEvent *)event
@@ -1451,8 +1470,10 @@ - (void)mouseUp:(NSEvent *)event
          case NSEventTypeRightMouseUp: num = 3; break;
          default: return; /* Unknown mouse event */
     }
-    PROCESS_EVENT("MouseEvent", "sOiii", "button_release_event", canvas,
-                  x, y, num);
+    process_event(
+        "MouseEvent", "{s:s, s:O, s:i, s:i, s:i}",
+        "name", "button_release_event", "canvas", canvas, "x", x, "y", y,
+        "num", num);
 }
 
 - (void)mouseMoved:(NSEvent *)event
@@ -1462,7 +1483,9 @@ - (void)mouseMoved:(NSEvent *)event
     location = [self convertPoint: location fromView: nil];
     x = location.x * device_scale;
     y = location.y * device_scale;
-    PROCESS_EVENT("MouseEvent", "sOii", "motion_notify_event", canvas, x, y);
+    process_event(
+        "MouseEvent", "{s:s, s:O, s:i, s:i}",
+        "name", "motion_notify_event", "canvas", canvas, "x", x, "y", y);
 }
 
 - (void)mouseDragged:(NSEvent *)event
@@ -1472,7 +1495,9 @@ - (void)mouseDragged:(NSEvent *)event
     location = [self convertPoint: location fromView: nil];
     x = location.x * device_scale;
     y = location.y * device_scale;
-    PROCESS_EVENT("MouseEvent", "sOii", "motion_notify_event", canvas, x, y);
+    process_event(
+        "MouseEvent", "{s:s, s:O, s:i, s:i}",
+        "name", "motion_notify_event", "canvas", canvas, "x", x, "y", y);
 }
 
 - (void)rightMouseDown:(NSEvent *)event { [self mouseDown: event]; }
@@ -1589,9 +1614,13 @@ - (void)keyDown:(NSEvent*)event
     int x = location.x * device_scale,
         y = location.y * device_scale;
     if (s) {
-        PROCESS_EVENT("KeyEvent", "sOsii", "key_press_event", canvas, s, x, y);
+        process_event(
+            "KeyEvent", "{s:s, s:O, s:s, s:i, s:i}",
+            "name", "key_press_event", "canvas", canvas, "key", s, "x", x, "y", y);
     } else {
-        PROCESS_EVENT("KeyEvent", "sOOii", "key_press_event", canvas, Py_None, x, y);
+        process_event(
+            "KeyEvent", "{s:s, s:O, s:O, s:i, s:i}",
+            "name", "key_press_event", "canvas", canvas, "key", Py_None, "x", x, "y", y);
     }
 }
 
@@ -1603,9 +1632,13 @@ - (void)keyUp:(NSEvent*)event
     int x = location.x * device_scale,
         y = location.y * device_scale;
     if (s) {
-        PROCESS_EVENT("KeyEvent", "sOsii", "key_release_event", canvas, s, x, y);
+        process_event(
+            "KeyEvent", "{s:s, s:O, s:s, s:i, s:i}",
+            "name", "key_release_event", "canvas", canvas, "key", s, "x", x, "y", y);
     } else {
-        PROCESS_EVENT("KeyEvent", "sOOii", "key_release_event", canvas, Py_None, x, y);
+        process_event(
+            "KeyEvent", "{s:s, s:O, s:O, s:i, s:i}",
+            "name", "key_release_event", "canvas", canvas, "key", Py_None, "x", x, "y", y);
     }
 }
 
@@ -1620,8 +1653,10 @@ - (void)scrollWheel:(NSEvent*)event
     NSPoint point = [self convertPoint: location fromView: nil];
     int x = (int)round(point.x * device_scale);
     int y = (int)round(point.y * device_scale - 1);
-    PROCESS_EVENT("MouseEvent", "sOiiOOi", "scroll_event", canvas,
-                  x, y, Py_None /* button */, Py_None /* key */, step);
+    process_event(
+        "MouseEvent", "{s:s, s:O, s:i, s:i, s:i}",
+        "name", "scroll_event", "canvas", canvas,
+        "x", x, "y", y, "step", step);
 }
 
 - (BOOL)acceptsFirstResponder
