Merge pull request #22161 from dstansby/polygon-verts-box

tacaswell · web-flow · commit da258539b7df · 2022-01-26T23:55:18.000-05:00
FIX: Add box when setting `PolygonSelector.verts`
diff --git a/lib/matplotlib/tests/test_widgets.py b/lib/matplotlib/tests/test_widgets.py
@@ -1373,17 +1373,20 @@ def test_polygon_selector_redraw(ax, draw_bounding_box):
     assert tool.verts == verts[0:2]
 
 
-@check_figures_equal()
-def test_polygon_selector_verts_setter(fig_test, fig_ref):
+@pytest.mark.parametrize('draw_bounding_box', [False, True])
+@check_figures_equal(extensions=['png'])
+def test_polygon_selector_verts_setter(fig_test, fig_ref, draw_bounding_box):
     verts = [(0.1, 0.4), (0.5, 0.9), (0.3, 0.2)]
     ax_test = fig_test.add_subplot()
 
-    tool_test = widgets.PolygonSelector(ax_test, onselect=noop)
+    tool_test = widgets.PolygonSelector(
+        ax_test, onselect=noop, draw_bounding_box=draw_bounding_box)
     tool_test.verts = verts
     assert tool_test.verts == verts
 
     ax_ref = fig_ref.add_subplot()
-    tool_ref = widgets.PolygonSelector(ax_ref, onselect=noop)
+    tool_ref = widgets.PolygonSelector(
+        ax_ref, onselect=noop, draw_bounding_box=draw_bounding_box)
     event_sequence = (polygon_place_vertex(*verts[0]) +
                       polygon_place_vertex(*verts[1]) +
                       polygon_place_vertex(*verts[2]) +
diff --git a/lib/matplotlib/widgets.py b/lib/matplotlib/widgets.py
@@ -3910,6 +3910,8 @@ def verts(self, xys):
         self._xys = [*xys, xys[0]]
         self._selection_completed = True
         self.set_visible(True)
+        if self._draw_box and self._box is None:
+            self._add_box()
         self._draw_polygon()
 
 
