closes #16593 setting ecolor turns off color cycling

story645 · story645 · commit dc16c70592b2 · 2020-02-28T13:13:18.000-05:00
Co-authored-by: tacaswell &lt;tcaswell@gmail.com&gt;

flake errors
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -3215,8 +3215,7 @@ def errorbar(self, x, y, yerr=None, xerr=None,
             # Remove alpha=0 color that _process_plot_format returns
             fmt_style_kwargs.pop('color')
 
-        if ('color' in kwargs or 'color' in fmt_style_kwargs or
-                ecolor is not None):
+        if ('color' in kwargs or 'color' in fmt_style_kwargs):
             base_style = {}
             if 'color' in kwargs:
                 base_style['color'] = kwargs.pop('color')
@@ -3227,6 +3226,7 @@ def errorbar(self, x, y, yerr=None, xerr=None,
         base_style.update(fmt_style_kwargs)
         if 'color' not in base_style:
             base_style['color'] = 'C0'
+            color = 'C0'
         if ecolor is None:
             ecolor = base_style['color']
         # make sure all the args are iterable; use lists not arrays to
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -3157,6 +3157,21 @@ def test_errorbar_colorcycle():
     assert mcolors.to_rgba(ln1.get_color()) == mcolors.to_rgba('C2')
 
 
+@check_figures_equal()
+def test_errorbar_cycle_ecolor(fig_test, fig_ref):
+    x = np.arange(0.1, 4, 0.5)
+    y = [np.exp(-x+n) for n in range(4)]
+    axt = fig_test.subplots()
+    for yi in y:
+        axt.errorbar(x, yi, yerr=(yi * 0.25), linestyle='-',
+                     marker='o', ecolor='black')
+
+    axr = fig_ref.subplots()
+    for yi, color in zip(y, ['C0', 'C1', 'C2', 'C3']):
+        axr.errorbar(x, yi, yerr=(yi * 0.25), linestyle='-',
+                     marker='o', color=color, ecolor='black')
+
+
 def test_errorbar_shape():
     fig = plt.figure()
     ax = fig.gca()
