Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit def5e9a

Browse files
committed
MNT: move log mask vs clip setting lower
Set the default in `LogScale.__init__`, not in `Axes.set_{x,y}scale`
1 parent 07a9450 commit def5e9a

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

lib/matplotlib/axes/_base.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2970,9 +2970,6 @@ def set_xscale(self, value, **kwargs):
29702970
29712971
matplotlib.scale.LogisticTransform : logit transform
29722972
"""
2973-
if value.lower() == "log": # Avoid headaches around zero.
2974-
kwargs.setdefault("nonposx", "clip")
2975-
29762973
g = self.get_shared_x_axes()
29772974
for ax in g.get_siblings(self):
29782975
ax.xaxis._set_scale(value, **kwargs)
@@ -3290,9 +3287,6 @@ def set_yscale(self, value, **kwargs):
32903287
32913288
matplotlib.scale.LogisticTransform : logit transform
32923289
"""
3293-
if value.lower() == "log": # Avoid headaches around zero.
3294-
kwargs.setdefault("nonposy", "clip")
3295-
32963290
g = self.get_shared_y_axes()
32973291
for ax in g.get_siblings(self):
32983292
ax.yaxis._set_scale(value, **kwargs)

lib/matplotlib/scale.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,11 +229,11 @@ def __init__(self, axis, **kwargs):
229229
if axis.axis_name == 'x':
230230
base = kwargs.pop('basex', 10.0)
231231
subs = kwargs.pop('subsx', None)
232-
nonpos = kwargs.pop('nonposx', 'mask')
232+
nonpos = kwargs.pop('nonposx', 'clip')
233233
else:
234234
base = kwargs.pop('basey', 10.0)
235235
subs = kwargs.pop('subsy', None)
236-
nonpos = kwargs.pop('nonposy', 'mask')
236+
nonpos = kwargs.pop('nonposy', 'clip')
237237

238238
if nonpos not in ['mask', 'clip']:
239239
raise ValueError("nonposx, nonposy kwarg must be 'mask' or 'clip'")

0 commit comments

Comments
 (0)