Merge pull request #24810 from QuLogic/widget-dicts

story645 · web-flow · commit e0e54b217382 · 2022-12-22T13:49:34.000-05:00
Don't modify dictionary input to widgets
diff --git a/lib/matplotlib/widgets.py b/lib/matplotlib/widgets.py
@@ -2729,9 +2729,11 @@ def __init__(self, ax, positions, direction, line_props=None,
         _api.check_in_list(['horizontal', 'vertical'], direction=direction)
         self._direction = direction
 
-        if line_props is None:
-            line_props = {}
-        line_props.update({'visible': False, 'animated': useblit})
+        line_props = {
+            **(line_props if line_props is not None else {}),
+            'visible': False,
+            'animated': useblit,
+        }
 
         line_fun = ax.axvline if self.direction == 'horizontal' else ax.axhline
 
@@ -3035,9 +3037,8 @@ def __init__(self, ax, onselect, drawtype='box',
             if props is None:
                 props = dict(facecolor='red', edgecolor='black',
                              alpha=0.2, fill=True)
-            props['animated'] = self.useblit
-            self._visible = props.pop('visible', self._visible)
-            self._props = props
+            self._props = {**props, 'animated': self.useblit}
+            self._visible = self._props.pop('visible', self._visible)
             to_draw = self._init_shape(**self._props)
             self.ax.add_patch(to_draw)
         if drawtype == 'line':
@@ -3048,8 +3049,7 @@ def __init__(self, ax, onselect, drawtype='box',
             if lineprops is None:
                 lineprops = dict(color='black', linestyle='-',
                                  linewidth=2, alpha=0.5)
-            lineprops['animated'] = self.useblit
-            self._props = lineprops
+            self._props = {**lineprops, 'animated': self.useblit}
             to_draw = Line2D([0, 0], [0, 0], visible=False, **self._props)
             self.ax.add_line(to_draw)
 
@@ -3622,10 +3622,12 @@ def __init__(self, ax, onselect=None, useblit=True, props=None,
                  button=None):
         super().__init__(ax, onselect, useblit=useblit, button=button)
         self.verts = None
-        if props is None:
-            props = dict()
-        # self.useblit may be != useblit, if the canvas doesn't support blit.
-        props.update(animated=self.useblit, visible=False)
+        props = {
+            **(props if props is not None else {}),
+            # Note that self.useblit may be != useblit, if the canvas doesn't
+            # support blitting.
+            'animated': self.useblit, 'visible': False,
+        }
         line = Line2D([], [], **props)
         self.ax.add_line(line)
         self._selection_artist = line
@@ -3760,8 +3762,7 @@ def __init__(self, ax, onselect, useblit=False,
 
         if props is None:
             props = dict(color='k', linestyle='-', linewidth=2, alpha=0.5)
-        props['animated'] = self.useblit
-        self._props = props
+        self._props = {**props, 'animated': self.useblit}
         self._selection_artist = line = Line2D([], [], **self._props)
         self.ax.add_line(line)
 
