MNT: Updating Colorbar zoom rectangle and selections

greglucas · greglucas · commit e25a898ec480 · 2021-09-20T06:51:03.000-06:00
Setting the zoom selector rectangle to the vertical/horizontal
limits of the colorbar, depending on the orientation.

Remove some mappable types from colorbar navigation. Certain mappables,
like categoricals and contours shouldn't be mapped by default due to
the limits of an axis carrying certain meaning. So, turn that off
for now and potentially revisit in the future.
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -4418,7 +4418,7 @@ def _get_pan_points(self, button, key, x, y):
         Helper function to return the new points after a pan.
 
         This helper function returns the points on the axis after a pan has
-        occurred. This a convenience method to abstract the pan logic
+        occurred. This is a convenience method to abstract the pan logic
         out of the base setter.
         """
         def format_deltas(key, dx, dy):
@@ -4475,7 +4475,6 @@ def format_deltas(key, dx, dy):
         points[~valid] = None
         return points
 
-
     def drag_pan(self, button, key, x, y):
         """
         Called when the mouse moves during a pan operation.
diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py
@@ -3166,6 +3166,15 @@ def drag_zoom(self, event):
             y1, y2 = ax.bbox.intervaly
         elif event.key == "y":
             x1, x2 = ax.bbox.intervalx
+
+        # A colorbar is one-dimensional, so we extend the zoom rectangle out
+        # to the edge of the axes bbox in the other dimension
+        if hasattr(ax, "_colorbar"):
+            if ax._colorbar.orientation == 'horizontal':
+                y1, y2 = ax.bbox.intervaly
+            else:
+                x1, x2 = ax.bbox.intervalx
+
         self.draw_rubberband(event, x1, y1, x2, y2)
 
     def release_zoom(self, event):
diff --git a/lib/matplotlib/colorbar.py b/lib/matplotlib/colorbar.py
@@ -422,7 +422,6 @@ def __init__(self, ax, mappable=None, *, cmap=None,
 
         self.ax = ax
         self.ax._axes_locator = _ColorbarAxesLocator(self)
-        ax.set(navigate=False)
 
         if extend is None:
             if (not isinstance(mappable, contour.ContourSet)
@@ -496,6 +495,16 @@ def __init__(self, ax, mappable=None, *, cmap=None,
         if isinstance(mappable, contour.ContourSet) and not mappable.filled:
             self.add_lines(mappable)
 
+        # Link the Axes and Colorbar for interactive use
+        self.ax._colorbar = self
+        for x in ["_get_view", "_set_view", "_set_view_from_bbox",
+                  "drag_pan", "start_pan", "end_pan"]:
+            setattr(self.ax, x, getattr(self, x))
+        # Don't navigate on any of these types of mappables
+        if (isinstance(self.norm, (colors.BoundaryNorm, colors.NoNorm)) or
+                isinstance(self.mappable, contour.ContourSet)):
+            self.ax.set_navigate(False)
+
     # Also remove ._patch after deprecation elapses.
     patch = _api.deprecate_privatize_attribute("3.5", alternative="ax")
 
