Merge pull request #13287 from cgohlke/patch-1

QuLogic · web-flow · commit e53ca14bd0b2 · 2019-01-25T18:28:25.000-05:00
Fix unsafe use of NULL pointer
diff --git a/src/file_compat.h b/src/file_compat.h
@@ -95,6 +95,7 @@ static NPY_INLINE FILE *mpl_PyFile_Dup(PyObject *file, char *mode, mpl_off_t *or
 #endif
     if (handle == NULL) {
         PyErr_SetString(PyExc_IOError, "Getting a FILE* from a Python file object failed");
+        return NULL;
     }
 
     /* Record the original raw file handle position */

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,7 @@ static NPY_INLINE FILE mpl_PyFile_Dup(PyObject file, char mode, mpl_off_t or`
`95`	`95`	`#endif`
`96`	`96`	`if (handle == NULL) {`
`97`	`97`	`PyErr_SetString(PyExc_IOError, "Getting a FILE* from a Python file object failed");`
	`98`	`+ return NULL;`
`98`	`99`	`}`
`99`	`100`
`100`	`101`	`/* Record the original raw file handle position */`