Improve alias signatures

timhoffm · timhoffm · commit e5b62d9ce32f · 2018-08-26T12:23:01.000+02:00
diff --git a/lib/matplotlib/cbook/__init__.py b/lib/matplotlib/cbook/__init__.py
@@ -1914,20 +1914,28 @@ class so far, an alias named ``get_alias`` will be defined; the same will
     if cls is None:  # Return the actual class decorator.
         return functools.partial(_define_aliases, alias_d)
 
-    def make_alias(name):  # Enforce a closure over *name*.
-        def method(self, *args, **kwargs):
-            return getattr(self, name)(*args, **kwargs)
-        return method
+    def make_alias(method):
+        import inspect
+        args = str(inspect.signature(method))[1:-1]  # remove parentheses
+        if args[:6] == 'self, ':
+            call_args = args[6:]
+        elif args == 'self':
+            call_args = ''
+        else:
+            raise RuntimeError('Unexpected signature: %s' % args)
+        alias_method = eval('lambda {}: self.{}({})'.format(
+            args, method.__name__, call_args))
+        alias_method.__doc__ = "Alias for `{}`.".format(method.__name__)
+        return alias_method
 
     for prop, aliases in alias_d.items():
         exists = False
         for prefix in ["get_", "set_"]:
             if prefix + prop in vars(cls):
                 exists = True
                 for alias in aliases:
-                    method = make_alias(prefix + prop)
+                    method = make_alias(getattr(cls, prefix + prop))
                     method.__name__ = prefix + alias
-                    method.__doc__ = "Alias for `{}`.".format(prefix + prop)
                     setattr(cls, prefix + alias, method)
         if not exists:
             raise ValueError(
