Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit e6a0c90

Browse files
committed
Update release guide
Add note about closing old milestones Separate push steps for branch and tag
1 parent 40a47e5 commit e6a0c90

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

doc/devel/release_guide.rst

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,8 @@ Micro versions should instead read::
8383
Check all active milestones for consistency. Older milestones should also backport
8484
to higher meso versions (e.g. ``v3.6.3`` and ``v3.6-doc`` should backport to both
8585
``v3.6.x`` and ``v3.7.x`` once the ``v3.7.x`` branch exists and while PR backports are
86-
still targeting ``v3.6.x``)
86+
still targeting ``v3.6.x``). Close milestones (and remilestone any issues/PRs) for versions
87+
which are unlikely to be produced.
8788

8889
Create the milestone for the next-next meso release (i.e. ``v3.9.0``, as ``v3.8.0``
8990
should already exist). While most active items should go in the next meso release,
@@ -294,9 +295,14 @@ it is important to move all branches away from the commit with the tag [#]_::
294295

295296
git commit --allow-empty
296297

298+
Push the branch to GitHub. This is done prior to pushing the tag as a last step in ensuring
299+
that the branch was fully up to date::
300+
301+
git push DANGER v3.7.x
302+
297303
Finally, push the tag to GitHub::
298304

299-
git push DANGER v3.7.x v3.7.0
305+
git push DANGER v3.7.0
300306

301307
Congratulations, the scariest part is done!
302308
This assumes the release branch has already been made.

0 commit comments

Comments
 (0)