Fix Issue 26821: [Bug]: ValueError: The truth value... when an ndarray is passed to the color kwarg of axes3d.scatter (#26834)

chiraagbalu · ksunden · web-flow · commit e6af5a339c7c · 2023-09-20T08:06:04.000+02:00
* FIX: [Bug]: ValueError: The truth value... when an ndarray is passed to the color kwarg of axes3d.scatter

* added smoke test to ensure no value error is thrown

* fixed smoke test to use fig canvas draw rather than plt show

* added an extra line and reduced line length to comply with flake8

* removed trailing whitespace

* Update lib/mpl_toolkits/mplot3d/tests/test_axes3d.py

Co-authored-by: Kyle Sunden &lt;git@ksunden.space&gt;

---------

Co-authored-by: Kyle Sunden &lt;git@ksunden.space&gt;
diff --git a/lib/mpl_toolkits/mplot3d/axes3d.py b/lib/mpl_toolkits/mplot3d/axes3d.py
@@ -2672,7 +2672,7 @@ def scatter(self, xs, ys, zs=0, zdir='z', s=20, c=None, depthshade=True,
         xs, ys, zs, s, c, color = cbook.delete_masked_points(
             xs, ys, zs, s, c, kwargs.get('color', None)
             )
-        if kwargs.get('color', None):
+        if kwargs.get("color") is not None:
             kwargs['color'] = color
 
         # For xs and ys, 2D scatter() will do the copying.
diff --git a/lib/mpl_toolkits/mplot3d/tests/test_axes3d.py b/lib/mpl_toolkits/mplot3d/tests/test_axes3d.py
@@ -2302,3 +2302,12 @@ def test_Poly3DCollection_init_value_error():
                         'or both for shade to work.'):
         poly = np.array([[0, 0, 1], [0, 1, 1], [0, 0, 0]], float)
         c = art3d.Poly3DCollection([poly], shade=True)
+
+
+def test_ndarray_color_kwargs_value_error():
+    # smoke test
+    # ensures ndarray can be passed to color in kwargs for 3d projection plot
+    fig = plt.figure()
+    ax = fig.add_subplot(111, projection='3d')
+    ax.scatter(1, 0, 0, color=np.array([0, 0, 0, 1]))
+    fig.canvas.draw()

Original file line number	Diff line number	Diff line change
`@@ -2672,7 +2672,7 @@ def scatter(self, xs, ys, zs=0, zdir='z', s=20, c=None, depthshade=True,`
`2672`	`2672`	`xs, ys, zs, s, c, color = cbook.delete_masked_points(`
`2673`	`2673`	`xs, ys, zs, s, c, kwargs.get('color', None)`
`2674`	`2674`	`)`
`2675`		`- if kwargs.get('color', None):`
	`2675`	`+ if kwargs.get("color") is not None:`
`2676`	`2676`	`kwargs['color'] = color`
`2677`	`2677`
`2678`	`2678`	`# For xs and ys, 2D scatter() will do the copying.`