Merge pull request #6145 from madphysicist/patch-1

tacaswell · tacaswell · commit e73859390f7d · 2016-03-13T16:31:22.000-04:00
MNT: fail earlier on unknown draw_style

Conflicts:
	.mailmap
diff --git a/.mailmap b/.mailmap
@@ -19,6 +19,7 @@ Jens Hedegaard Nielsen <jenshnielsen@gmail.com> Jens H Nielsen <jenshnielsen@gma
 Jens Hedegaard Nielsen <jenshnielsen@gmail.com> Jens H. Nielsen <jenshnielsen@gmail.com>
 Jens Hedegaard Nielsen <jenshnielsen@gmail.com> Jens H. Nielsen <jens.nielsen@ucl.ac.uk>
 John Hunter <jdh2358@gmail.com> jdh2358 <jdh2358@gmail.com>
+Joseph Fox-Rabinovitz <jfoxrabinovitz@gmail.com> Mad Physicist <madphysicist@users.noreply.github.com>
 Jouni K. Seppänen <jks@iki.fi> Jouni K. Seppänen <jks@iki.fi>
 Julien Schueller <julien.schueller@gmail.com> jschueller <schueller@porsche-l64.phimeca.lan>
 Julien Schueller <julien.schueller@gmail.com> Julien Schueller <schueller@bx-l64.phimeca.lan>
diff --git a/lib/matplotlib/lines.py b/lib/matplotlib/lines.py
@@ -986,6 +986,9 @@ def set_drawstyle(self, drawstyle):
         ACCEPTS: ['default' | 'steps' | 'steps-pre' | 'steps-mid' |
                   'steps-post']
         """
+        if drawstyle not in self.drawStyles:
+            raise ValueError('Unrecognized drawstyle ' +
+                             ' '.join(self.drawStyleKeys))
         if self._drawstyle != drawstyle:
             self.stale = True
         self._drawstyle = drawstyle
diff --git a/lib/matplotlib/tests/test_lines.py b/lib/matplotlib/tests/test_lines.py
@@ -118,6 +118,29 @@ def test_valid_linestyles():
         line.set_linestyle('aardvark')
 
 
+@cleanup
+def test_drawstyle_variants():
+    fig = plt.figure()
+    ax = fig.add_subplot(1, 1, 1)
+    for ds in ("default", "steps-mid", "steps-pre", "steps-post",
+               "steps"):
+        ax.plot(range(10), drawstyle=ds)
+
+    fig.canvas.draw()
+    assert True
+
+
+@cleanup
+def test_valid_drawstyles():
+    if sys.version_info[:2] < (2, 7):
+        raise nose.SkipTest("assert_raises as context manager "
+                            "not supported with Python < 2.7")
+
+    line = mlines.Line2D([], [])
+    with assert_raises(ValueError):
+        line.set_drawstyle('foobar')
+
+
 @image_comparison(baseline_images=['line_collection_dashes'], remove_text=True)
 def test_set_line_coll_dash_image():
     fig = plt.figure()

-Original file line number
+Diff line change
 Jens Hedegaard Nielsen <[email protected]> Jens H. Nielsen <[email protected]>
 Jens Hedegaard Nielsen <[email protected]> Jens H. Nielsen <[email protected]>
 John Hunter <[email protected]> jdh2358 <[email protected]>
 +Joseph Fox-Rabinovitz <[email protected]> Mad Physicist <[email protected]>
 Jouni K. Seppänen <[email protected]> Jouni K. Seppänen <[email protected]>
 Julien Schueller <[email protected]> jschueller <[email protected]>
 Julien Schueller <[email protected]> Julien Schueller <[email protected]>