Remove unneeded _update_transScale calls in _init_axis.

anntzer · anntzer · commit e8973842f7a9 · 2022-12-06T09:47:10.000+01:00
_init_axis is called only in the Axes constructor, where it is followed
by a call to clear, which itself already calls _update_transScale (which
is needed to take into account the axis scales that get set in it).  So
_init_axis doesn't need to call _update_transScale itself.  Removing it
avoids showcasing a private method in the custom_projection demo, and
helps moving towards a system where updating an axis scale directly
invalidates whatever is necessary (e.g. via a TransformWrapper) instead
of requiring manual invalidation calls (i.e. _update_transScale).
diff --git a/examples/misc/custom_projection.py b/examples/misc/custom_projection.py
@@ -50,7 +50,6 @@ def _init_axis(self):
         # Do not register xaxis or yaxis with spines -- as done in
         # Axes._init_axis() -- until GeoAxes.xaxis.clear() works.
         # self.spines['geo'].register_axis(self.yaxis)
-        self._update_transScale()
 
     def clear(self):
         # docstring inherited
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -822,7 +822,6 @@ def _init_axis(self):
         self.yaxis = maxis.YAxis(self)
         self.spines.left.register_axis(self.yaxis)
         self.spines.right.register_axis(self.yaxis)
-        self._update_transScale()
 
     def set_figure(self, fig):
         # docstring inherited
diff --git a/lib/matplotlib/projections/geo.py b/lib/matplotlib/projections/geo.py
@@ -35,7 +35,6 @@ def _init_axis(self):
         # Do not register xaxis or yaxis with spines -- as done in
         # Axes._init_axis() -- until GeoAxes.xaxis.clear() works.
         # self.spines['geo'].register_axis(self.yaxis)
-        self._update_transScale()
 
     def clear(self):
         # docstring inherited
diff --git a/lib/matplotlib/projections/polar.py b/lib/matplotlib/projections/polar.py
@@ -792,11 +792,9 @@ def _init_axis(self):
         # This is moved out of __init__ because non-separable axes don't use it
         self.xaxis = ThetaAxis(self)
         self.yaxis = RadialAxis(self)
-        # Calling polar_axes.xaxis.clear() or polar_axes.xaxis.clear()
-        # results in weird artifacts. Therefore we disable this for
-        # now.
+        # Calling polar_axes.xaxis.clear() or polar_axes.yaxis.clear()
+        # results in weird artifacts. Therefore we disable this for now.
         # self.spines['polar'].register_axis(self.yaxis)
-        self._update_transScale()
 
     def _set_lim_and_transforms(self):
         # A view limit where the minimum radius can be locked if the user
