Merge pull request #13984 from dstansby/3d-tick-color

tacaswell · web-flow · commit e8c0b5ec05dc · 2019-04-20T17:10:51.000-04:00
ENH: Allow setting tick colour on 3D axes
diff --git a/lib/mpl_toolkits/mplot3d/axis3d.py b/lib/mpl_toolkits/mplot3d/axis3d.py
@@ -81,8 +81,7 @@ def __init__(self, adir, v_intervalx, d_intervalx, axes, *args,
                            'ha': 'center'},
                  'tick': {'inward_factor': 0.2,
                           'outward_factor': 0.1,
-                          'linewidth': rcParams['lines.linewidth'],
-                          'color': 'k'},
+                          'linewidth': rcParams['lines.linewidth']},
                  'axisline': {'linewidth': 0.75,
                               'color': (0, 0, 0, 1)},
                  'grid': {'color': (0.9, 0.9, 0.9, 1),
@@ -97,10 +96,7 @@ def __init__(self, adir, v_intervalx, d_intervalx, axes, *args,
                           'outward_factor': 0.1,
                           'linewidth': rcParams.get(
                               adir + 'tick.major.width',
-                              rcParams['xtick.major.width']),
-                          'color': rcParams.get(
-                              adir + 'tick.color',
-                              rcParams['xtick.color'])},
+                              rcParams['xtick.major.width'])},
                  'axisline': {'linewidth': rcParams['axes.linewidth'],
                               'color': rcParams['axes.edgecolor']},
                  'grid': {'color': rcParams['grid.color'],
@@ -265,7 +261,7 @@ def draw(self, renderer):
         dx, dy = (self.axes.transAxes.transform([peparray[0:2, 1]]) -
                   self.axes.transAxes.transform([peparray[0:2, 0]]))[0]
 
-        lxyz = 0.5*(edgep1 + edgep2)
+        lxyz = 0.5 * (edgep1 + edgep2)
 
         # A rough estimate; points are ambiguous since 3D plots rotate
         ax_scale = self.axes.bbox.size / self.figure.bbox.size
@@ -391,7 +387,6 @@ def draw(self, renderer):
             ticksign = -1
 
         for tick in ticks:
-
             # Get tick line positions
             pos = copy.copy(edgep1)
             pos[index] = tick.get_loc()
@@ -420,7 +415,6 @@ def draw(self, renderer):
 
             tick_update_position(tick, (x1, x2), (y1, y2), (lx, ly))
             tick.tick1line.set_linewidth(info['tick']['linewidth'])
-            tick.tick1line.set_color(info['tick']['color'])
             tick.draw(renderer)
 
         renderer.close_group('axis3d')
diff --git a/lib/mpl_toolkits/tests/test_mplot3d.py b/lib/mpl_toolkits/tests/test_mplot3d.py
@@ -923,3 +923,20 @@ def test_proj3d_deprecated():
 
     with pytest.warns(MatplotlibDeprecationWarning):
         proj3d.proj_trans_clip_points(np.ones((4, 3)), M)
+
+
+def test_ax3d_tickcolour():
+    fig = plt.figure()
+    ax = Axes3D(fig)
+
+    ax.tick_params(axis='x', colors='red')
+    ax.tick_params(axis='y', colors='red')
+    ax.tick_params(axis='z', colors='red')
+    fig.canvas.draw()
+
+    for tick in ax.xaxis.get_major_ticks():
+        assert tick.tick1line._color == 'red'
+    for tick in ax.yaxis.get_major_ticks():
+        assert tick.tick1line._color == 'red'
+    for tick in ax.zaxis.get_major_ticks():
+        assert tick.tick1line._color == 'red'
