FIX: add None to axes.titlepad

jklymak · jklymak · commit e960b5b91377 · 2020-03-21T20:01:46.000-07:00
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -169,12 +169,11 @@ def set_title(self, label, fontdict=None, loc=None, pad=None, **kwargs):
         titlecolor = rcParams['axes.titlecolor']
         if not cbook._str_lower_equal(titlecolor, 'auto'):
             default["color"] = titlecolor
+
         if pad is None:
             pad = rcParams['axes.titlepad']
-            self._autotitlepos = None
-        else:
-            self._autotitlepos = False
-        self._set_title_offset_trans(float(pad))
+        self._set_title_offset_trans(pad)
+
         title.set_text(label)
         title.update(default)
         if fontdict is not None:
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -1063,12 +1063,8 @@ def cla(self):
             verticalalignment='baseline',
             horizontalalignment='right',
             )
-        title_offset_points = mpl.rcParams['axes.titlepad']
-        # refactor this out so it can be called in ax.set_title if
-        # pad argument used...
-        self._set_title_offset_trans(title_offset_points)
-        # determine if the title position has been set manually:
-        self._autotitlepos = None
+
+        self._set_title_offset_trans(mpl.rcParams['axes.titlepad'])
 
         for _title in (self.title, self._left_title, self._right_title):
             self._set_artist_props(_title)
@@ -1120,13 +1116,20 @@ def set_facecolor(self, color):
         self.stale = True
         return self.patch.set_facecolor(color)
 
-    def _set_title_offset_trans(self, title_offset_points):
+    def _set_title_offset_trans(self, pad):
         """
         Set the offset for the title either from :rc:`axes.titlepad`
         or from set_title kwarg ``pad``.
         """
+
+        if pad is None:
+            self._autotitlepos = True
+            pad = 6  # default.
+        else:
+            self._autotitlepos = False
+
         self.titleOffsetTrans = mtransforms.ScaledTranslation(
-                0.0, title_offset_points / 72,
+                0.0, pad / 72,
                 self.figure.dpi_scale_trans)
         for _title in (self.title, self._left_title, self._right_title):
             _title.set_transform(self.transAxes + self.titleOffsetTrans)
diff --git a/lib/matplotlib/rcsetup.py b/lib/matplotlib/rcsetup.py
@@ -1213,7 +1213,7 @@ def _convert_validator_spec(key, conv):
     'axes.titlelocation':    ['center', ['left', 'center', 'right']],  # alignment of axes title
     'axes.titleweight':      ['normal', validate_fontweight],  # font weight of axes title
     'axes.titlecolor':       ['auto', validate_color_or_auto],  # font color of axes title
-    'axes.titlepad':         [6.0, validate_float],  # pad from axes top to title in points
+    'axes.titlepad':         [None, validate_float_or_None],  # pad from axes top to title in points.  None means to allow autopadding.
     'axes.grid':             [False, validate_bool],   # display grid or not
     'axes.grid.which':       ['major', ['minor', 'both', 'major']],  # set whether the grid is drawn on
                                                                      # 'major' 'minor' or 'both' ticks
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -5477,9 +5477,6 @@ def test_title_noauto_pad():
                    bottom=True, top=True, labelbottom=True, labeltop=True)
     fig.canvas.draw()
     assert ax.title.get_position()[1] == 1.0
-    ax.set_title(f"Title 2")
-    fig.canvas.draw()
-    assert ax.title.get_position()[1] > 1.04
 
 
 def test_offset_label_color():
diff --git a/matplotlibrc.template b/matplotlibrc.template
@@ -326,7 +326,7 @@
 #mathtext.sf:  sans
 #mathtext.tt:  monospace
 #mathtext.fallback: cm  # Select fallback font from ['cm' (Computer Modern), 'stix'
-                        # 'stixsans'] when a symbol can not be found in one of the 
+                        # 'stixsans'] when a symbol can not be found in one of the
                         # custom math fonts. Select 'None' to not perform fallback
                         # and replace the missing character by a dummy symbol.
 #mathtext.default: it  # The default font to use for math.
@@ -352,7 +352,8 @@
 #axes.titleweight:   normal  # font weight of title
 #axes.titlecolor:    auto    # color of the axes title, auto falls back to
                              # text.color as default value
-#axes.titlepad:      6.0     # pad between axes and title in points
+#axes.titlepad:      None    # pad between axes and title in points.
+                             # None means to autoplace the title.
 #axes.labelsize:     medium  # fontsize of the x any y labels
 #axes.labelpad:      4.0     # space between label and axis
 #axes.labelweight:   normal  # weight of the x and y labels
