Initialize members of PathClipper and check for m_has_init

pwohlhart · web-flow · commit eda0cbdee4b2 · 2021-04-15T11:56:18.000-07:00
MemorySanitizer complains about use-of-uninitialized-value in one of my tests.

WARNING: MemorySanitizer: use-of-uninitialized-value [....]src/path_converters.h:425:42 in PathClipper&lt;PathNanRemover&lt;agg::conv_transform&lt;py::PathIterator, agg::trans_affine&gt; &gt; &gt;::vertex(double*, double*)
diff --git a/src/path_converters.h b/src/path_converters.h
@@ -306,7 +306,11 @@ class PathClipper : public EmbeddedQueue<3>
         : m_source(&source),
           m_do_clipping(do_clipping),
           m_cliprect(-1.0, -1.0, width + 1.0, height + 1.0),
+          m_lastX(nan("")),
+          m_lastY(nan("")),
           m_moveto(true),
+          m_initX(nan("")),
+          m_initY(nan("")),
           m_has_init(false)
     {
         // empty
@@ -316,7 +320,11 @@ class PathClipper : public EmbeddedQueue<3>
         : m_source(&source),
           m_do_clipping(do_clipping),
           m_cliprect(rect),
+          m_lastX(nan("")),
+          m_lastY(nan("")),
           m_moveto(true),
+          m_initX(nan("")),
+          m_initY(nan("")),
           m_has_init(false)
     {
         m_cliprect.x1 -= 1.0;
@@ -432,7 +440,7 @@ class PathClipper : public EmbeddedQueue<3>
                 return code;
             }
 
-            if (m_moveto &&
+            if (m_moveto && m_has_init &&
                 m_lastX >= m_cliprect.x1 &&
                 m_lastX <= m_cliprect.x2 &&
                 m_lastY >= m_cliprect.y1 &&
