Remove unused bbox arg to _convert_agg_to_wx_bitmap.

anntzer · anntzer · commit eec6ca591e03 · 2021-12-05T18:37:17.000+01:00
This arg is unused since 744b7f8; we only need to clip when actually blitting to the destination bitmap, not when first converting the agg buffer to a bitmap. Also make the conversion function directly take an rgba buffer as input and rename it, as it isn't really agg-specific. Also switch the construction of MemoryDC to directly pass in the Selected bitmap as arg, rather that having a separate SelectObject call (this is supported all the way back since wx3).
diff --git a/lib/matplotlib/backends/backend_wx.py b/lib/matplotlib/backends/backend_wx.py
@@ -332,8 +332,7 @@ def __init__(self, bitmap, renderer):
 
         dc, gfx_ctx = self._cache.get(bitmap, (None, None))
         if dc is None:
-            dc = wx.MemoryDC()
-            dc.SelectObject(bitmap)
+            dc = wx.MemoryDC(bitmap)
             gfx_ctx = wx.GraphicsContext.Create(dc)
             gfx_ctx._lastcliprect = None
             self._cache[bitmap] = dc, gfx_ctx
diff --git a/lib/matplotlib/backends/backend_wxagg.py b/lib/matplotlib/backends/backend_wxagg.py
@@ -27,63 +27,30 @@ def draw(self, drawDC=None):
         Render the figure using agg.
         """
         FigureCanvasAgg.draw(self)
-
-        self.bitmap = _convert_agg_to_wx_bitmap(self.get_renderer(), None)
+        self.bitmap = _rgba_to_wx_bitmap(self.get_renderer().buffer_rgba())
         self._isDrawn = True
         self.gui_repaint(drawDC=drawDC)
 
     def blit(self, bbox=None):
         # docstring inherited
+        bitmap = _rgba_to_wx_bitmap(self.get_renderer().buffer_rgba())
         if bbox is None:
-            self.bitmap = _convert_agg_to_wx_bitmap(self.get_renderer(), None)
-            self.gui_repaint()
-            return
-
-        srcBmp = _convert_agg_to_wx_bitmap(self.get_renderer(), None)
-        srcDC = wx.MemoryDC()
-        srcDC.SelectObject(srcBmp)
-
-        destDC = wx.MemoryDC()
-        destDC.SelectObject(self.bitmap)
-
-        x = int(bbox.x0)
-        y = int(self.bitmap.GetHeight() - bbox.y1)
-        destDC.Blit(x, y, int(bbox.width), int(bbox.height), srcDC, x, y)
-
-        destDC.SelectObject(wx.NullBitmap)
-        srcDC.SelectObject(wx.NullBitmap)
+            self.bitmap = bitmap
+        else:
+            srcDC = wx.MemoryDC(bitmap)
+            destDC = wx.MemoryDC(self.bitmap)
+            x = int(bbox.x0)
+            y = int(self.bitmap.GetHeight() - bbox.y1)
+            destDC.Blit(x, y, int(bbox.width), int(bbox.height), srcDC, x, y)
+            destDC.SelectObject(wx.NullBitmap)
+            srcDC.SelectObject(wx.NullBitmap)
         self.gui_repaint()
 
 
-def _convert_agg_to_wx_bitmap(agg, bbox):
-    """
-    Convert the region of the agg buffer bounded by bbox to a wx.Bitmap.  If
-    bbox is None, the entire buffer is converted.
-    Note: agg must be a backend_agg.RendererAgg instance.
-    """
-    if bbox is None:
-        # agg => rgba buffer -> bitmap
-        return wx.Bitmap.FromBufferRGBA(int(agg.width), int(agg.height),
-                                        agg.buffer_rgba())
-    else:
-        # agg => rgba buffer -> bitmap => clipped bitmap
-        srcBmp = wx.Bitmap.FromBufferRGBA(int(agg.width), int(agg.height),
-                                          agg.buffer_rgba())
-        srcDC = wx.MemoryDC()
-        srcDC.SelectObject(srcBmp)
-
-        destBmp = wx.Bitmap(int(bbox.width), int(bbox.height))
-        destDC = wx.MemoryDC()
-        destDC.SelectObject(destBmp)
-
-        x = int(bbox.x0)
-        y = int(int(agg.height) - bbox.y1)
-        destDC.Blit(0, 0, int(bbox.width), int(bbox.height), srcDC, x, y)
-
-        srcDC.SelectObject(wx.NullBitmap)
-        destDC.SelectObject(wx.NullBitmap)
-
-        return destBmp
+def _rgba_to_wx_bitmap(rgba):
+    """Convert an RGBA buffer to a wx.Bitmap."""
+    h, w, _ = rgba.shape
+    return wx.Bitmap.FromBufferRGBA(w, h, rgba)
 
 
 @_BackendWx.export
