Merge pull request #27821 from DWesl/patch-5

ksunden · web-flow · commit efcca8deaf72 · 2024-03-07T14:10:33.000-06:00
BLD,Cygwin: Include Python.h first in various C++ files
diff --git a/.github/workflows/cygwin.yml b/.github/workflows/cygwin.yml
@@ -243,7 +243,7 @@ jobs:
         shell: bash.exe -eo pipefail -o igncr "{0}"
         id: cygwin-run-pytest
         run: |
-          xvfb-run pytest -rfEsXR -n auto \
+          xvfb-run pytest-3.${{ matrix.python-minor-version }} -rfEsXR -n auto \
             --maxfail=50 --timeout=300 --durations=25 \
             --cov-report=xml --cov=lib --log-level=DEBUG --color=yes
 
diff --git a/src/_backend_agg.cpp b/src/_backend_agg.cpp
@@ -2,6 +2,7 @@
 
 #define NO_IMPORT_ARRAY
 
+#include <Python.h>
 #include "_backend_agg.h"
 #include "mplutils.h"
 
diff --git a/src/_c_internal_utils.cpp b/src/_c_internal_utils.cpp
@@ -1,3 +1,6 @@
+#include <Python.h>
+/* Python.h must be included before any system headers,
+    to ensure visibility macros are properly set. */
 #include <stdexcept>
 
 #ifdef _WIN32
diff --git a/src/_tkagg.cpp b/src/_tkagg.cpp
@@ -9,6 +9,7 @@
 // rewritten, we have removed the PIL licensing information.  If you want PIL,
 // you can get it at https://python-pillow.org/
 
+#include <Python.h>
 #include <memory>
 #include <new>
 #include <stdexcept>
diff --git a/src/_ttconv.cpp b/src/_ttconv.cpp
@@ -5,9 +5,8 @@
 
   Python wrapper for TrueType conversion library in ../ttconv.
  */
-#include "mplutils.h"
-
 #include <pybind11/pybind11.h>
+#include "mplutils.h"
 #include "pprdrv.h"
 #include <vector>
 
diff --git a/src/ft2font.h b/src/ft2font.h
@@ -2,8 +2,13 @@
 
 /* A python interface to FreeType */
 #pragma once
+
 #ifndef MPL_FT2FONT_H
 #define MPL_FT2FONT_H
+
+#define PY_SSIZE_T_CLEAN
+#include <Python.h>
+
 #include <vector>
 #include<set>
 #include <stdint.h>
@@ -19,9 +24,6 @@ extern "C" {
 #include FT_TRUETYPE_TABLES_H
 }
 
-#define PY_SSIZE_T_CLEAN
-#include <Python.h>
-
 /*
  By definition, FT_FIXED as 2 16bit values stored in a single long.
  */
diff --git a/src/numpy_cpp.h b/src/numpy_cpp.h
@@ -14,10 +14,6 @@
  * original.
  */
 
-#include "py_exceptions.h"
-
-#include <complex>
-
 #ifdef _POSIX_C_SOURCE
 #    undef _POSIX_C_SOURCE
 #endif
@@ -40,6 +36,10 @@
 #include <Python.h>
 #include <numpy/ndarrayobject.h>
 
+#include "py_exceptions.h"
+
+#include <complex>
+
 namespace numpy
 {
 
