Don't use 'renderer' argument to Axis._update_ticks.

efiring · efiring · commit f0dc735aa2ce · 2018-04-08T14:03:32.000-10:00
It was not being used.  Now we warn that it will be removed
in 3.1.

Note that the completely different AxisArtist._update_ticks
does use its renderer argument.
diff --git a/lib/matplotlib/axis.py b/lib/matplotlib/axis.py
@@ -985,7 +985,7 @@ def get_ticklabel_extents(self, renderer):
         of the axes.
         """
 
-        ticks_to_draw = self._update_ticks(renderer)
+        ticks_to_draw = self._update_ticks()
         ticklabelBoxes, ticklabelBoxes2 = self._get_tick_bboxes(ticks_to_draw,
                                                                 renderer)
 
@@ -1008,13 +1008,17 @@ def get_smart_bounds(self):
         """get whether the axis has smart bounds"""
         return self._smart_bounds
 
-    def _update_ticks(self, renderer):
+    def _update_ticks(self, renderer=None):
         """
         Update ticks (position and labels) using the current data
         interval of the axes. Returns a list of ticks that will be
         drawn.
         """
 
+        if renderer is not None:
+            cbook.warn_deprecated("Axis._update_ticks should be called with"
+                                  " no arguments; the 'renderer' argument"
+                                  " is ignored and will be removed in 3.1")
         interval = self.get_view_interval()
         tick_tups = list(self.iter_ticks())  # iter_ticks calls the locator
         if self._smart_bounds and tick_tups:
@@ -1131,7 +1135,7 @@ def get_tightbbox(self, renderer):
         if not self.get_visible():
             return
 
-        ticks_to_draw = self._update_ticks(renderer)
+        ticks_to_draw = self._update_ticks()
 
         self._update_label_position(renderer)
 
@@ -1174,7 +1178,7 @@ def draw(self, renderer, *args, **kwargs):
             return
         renderer.open_group(__name__)
 
-        ticks_to_draw = self._update_ticks(renderer)
+        ticks_to_draw = self._update_ticks()
         ticklabelBoxes, ticklabelBoxes2 = self._get_tick_bboxes(ticks_to_draw,
                                                                 renderer)
 
@@ -1884,7 +1888,7 @@ def _get_tick_boxes_siblings(self, renderer):
         grp = self.figure._align_xlabel_grp
         # if we want to align labels from other axes:
         for nn, axx in enumerate(grp.get_siblings(self.axes)):
-            ticks_to_draw = axx.xaxis._update_ticks(renderer)
+            ticks_to_draw = axx.xaxis._update_ticks()
             tlb, tlb2 = axx.xaxis._get_tick_bboxes(ticks_to_draw, renderer)
             bboxes.extend(tlb)
             bboxes2.extend(tlb2)
@@ -2253,7 +2257,7 @@ def _get_tick_boxes_siblings(self, renderer):
         grp = self.figure._align_ylabel_grp
         # if we want to align labels from other axes:
         for axx in grp.get_siblings(self.axes):
-            ticks_to_draw = axx.yaxis._update_ticks(renderer)
+            ticks_to_draw = axx.yaxis._update_ticks()
             tlb, tlb2 = axx.yaxis._get_tick_bboxes(ticks_to_draw, renderer)
             bboxes.extend(tlb)
             bboxes2.extend(tlb2)
