Future-proof dark theme support in wxAgg backend in case svg icons have more complex stroke styles in the future.

jmoraleda · jmoraleda · commit f0e0cb6ecaae · 2023-09-11T03:14:38.000-04:00
diff --git a/lib/matplotlib/backends/backend_wx.py b/lib/matplotlib/backends/backend_wx.py
@@ -1070,7 +1070,7 @@ def _icon(name):
             fg_lum = (.299 * fg.red + .587 * fg.green + .114 * fg.blue) / 255
             dark = fg_lum - bg_lum > .2
         if dark:
-            svg = svg.replace(b'style="fill:black;"', b'style="fill:white;"')
+            svg = svg.replace(b'fill:black;', b'fill:white;')
         toolbarIconSize = wx.ArtProvider().GetDIPSizeHint(wx.ART_TOOLBAR)
         return wx.BitmapBundle.FromSVG(svg, toolbarIconSize)
 
