Merge pull request #12051 from timhoffm/is-bool

NelleV · web-flow · commit f1f66b0c5e23 · 2018-09-07T11:26:23.000-07:00
Is bool
diff --git a/lib/matplotlib/__init__.py b/lib/matplotlib/__init__.py
@@ -1730,7 +1730,7 @@ def inner(ax, *args, data=None, **kwargs):
                 if not isinstance(label, str):
                     label = None
 
-                if (replace_names is None) or (replace_all_args is True):
+                if replace_names is None or replace_all_args:
                     # all should be replaced
                     args = tuple(_replacer(data, a) for
                                  j, a in enumerate(args))
diff --git a/lib/matplotlib/backends/_backend_tk.py b/lib/matplotlib/backends/_backend_tk.py
@@ -334,8 +334,8 @@ def _update_pointer_position(self, guiEvent=None):
                 self.leave_notify_event(guiEvent)
 
     def draw_idle(self):
-        'update drawing area only if idle'
-        if self._idle is False:
+        """Update the drawing area if idle."""
+        if not self._idle:
             return
 
         self._idle = False
diff --git a/lib/matplotlib/bezier.py b/lib/matplotlib/bezier.py
@@ -279,7 +279,7 @@ def split_path_inout(path, inside, tolerence=0.01, reorder_inout=False):
         path_out = Path(concat([verts_right, path.vertices[i:]]),
                         concat([codes_right, path.codes[i:]]))
 
-    if reorder_inout and begin_inside is False:
+    if reorder_inout and not begin_inside:
         path_in, path_out = path_out, path_in
 
     return path_in, path_out
diff --git a/lib/matplotlib/tests/test_artist.py b/lib/matplotlib/tests/test_artist.py
@@ -36,7 +36,7 @@ def test_patch_transform_of_none():
     # Providing a transform of None puts the ellipse in device coordinates.
     e = mpatches.Ellipse(xy_pix, width=120, height=120, fc='coral',
                          transform=None, alpha=0.5)
-    assert e.is_transform_set() is True
+    assert e.is_transform_set()
     ax.add_patch(e)
     assert isinstance(e._transform, mtransforms.IdentityTransform)
 
@@ -51,10 +51,10 @@ def test_patch_transform_of_none():
     e = mpatches.Ellipse(xy_pix, width=120, height=120, fc='coral',
                          alpha=0.5)
     intermediate_transform = e.get_transform()
-    assert e.is_transform_set() is False
+    assert not e.is_transform_set()
     ax.add_patch(e)
     assert e.get_transform() != intermediate_transform
-    assert e.is_transform_set() is True
+    assert e.is_transform_set()
     assert e._transform == ax.transData
 
 
diff --git a/lib/matplotlib/tests/test_legend.py b/lib/matplotlib/tests/test_legend.py
@@ -494,7 +494,7 @@ def test_legend_title_empty():
     ax.plot(range(10))
     leg = ax.legend()
     assert leg.get_title().get_text() == ""
-    assert leg.get_title().get_visible() is False
+    assert not leg.get_title().get_visible()
 
 
 def test_legend_proper_window_extent():
